refactor: Introducing a CallbackPlugin to wrap the old style Callbacks #716
+1,300
−236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_853407402
branch
4 times, most recently
from
11676d3 to
157ffd8
Compare
The goal is to unify the processing of Plugins and Callbacks. We should consider depercating and removing the old Callbacks. There are a bunch of cyclical dependencies caused by requests back to the agent to get specific Callbacks. The next step will be to augmet the InvocationContext's PluginManager with the appropriate agent specific callbacks PiperOrigin-RevId: 853407402
copybara-service
bot
force-pushed
the
test_853407402
branch
from
157ffd8 to
c20daba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: Introducing a CallbackPlugin to wrap the old style Callbacks
The goal is to unify the processing of Plugins and Callbacks. We should consider depercating and removing the old Callbacks.
There are a bunch of cyclical dependencies caused by requests back to the agent to get specific Callbacks. The next step will be to augmet the InvocationContext's PluginManager with the appropriate agent specific callbacks