feat: more generic url #2251
Closed
feat: more generic url #2251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure who to ping for a review, so based on contributions, @seanzhougoogle @xuanyang15 @wuliang229 could you please take a look or tag a relevant person? Thank you. |
|
Why the @adk-bot didn't react here? |
|
Superseded by #2556 because for some reason this PR didn't trigger the bot and no reviewer was assigned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2238.
This is more generic and allows you to set http or https as needed, which is crucial in larger ecosystems.
Does it make sense to add some tests for it? For the original logic of composing url there were no specific tests either.
And as I am using windows it's non-trivial to run tests, and they are failing on completely unrelated parts of code.