chore: Reformatted the product-catalog-ad-generation sample by ensuring black, isort, and flake8 pass #764
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommywagz
force-pushed
the
format/python/product-catalog-ad-generation
branch
from
af0046b to
20de151
Compare
tommywagz
approved these changes
Jan 12, 2026
Collaborator
tommywagz
left a comment
tommywagz
left a comment
There was a problem hiding this comment.
Generally LGTM, assuming the reference table with the BQ table was commented to prevent blocking errors
Collaborator
There was a problem hiding this comment.
Just curious, why is the table reference commented out? Looks good though
Collaborator
|
Even with the git head set to (20de151) there are still conflicts to resolve with main. I'll resolve the conflicts and request your review. |
tommywagz
requested review from
eliasecchig,
gulliantonio,
jackwotherspoon and
lavinigam-gcp
as code owners
happyhuman
force-pushed
the
format/python/product-catalog-ad-generation
branch
from
4d3ab81 to
c7ae9d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.