Remove hardcoded path references#212
Remove hardcoded path references#212RichardBronosky wants to merge 1 commit intogoogle:aiyprojectsfrom
Conversation
Remove the assumed /home/pi/AIY-projects-python project path. This is easily done because of the previous cd call change the CWD to the project path. This changed is needed because of conflicting instructions in HACKING.md This resolves google#211
|
This would not work very well in the distant case where a user runs the install-deps.sh while in the home directory or anywhere else for that matter. Ideally we should not be assuming anything here. A better approach would be to hard code a path somewhere in the root of the repo and the use references to that everywhere. |
|
@ameer1234567890 look at line 32. Where the script is run from is irrelevant. The script |
drigz
left a comment
drigz
left a comment
There was a problem hiding this comment.
Thanks for the PR! I've been trying to avoid assuming /home/pi as it breaks DietPi.
| env/bin/pip install -r requirements.txt | ||
| echo "/home/pi/AIY-projects-python/src" > \ | ||
| /home/pi/AIY-projects-python/env/lib/python3.5/site-packages/aiy.pth | ||
| echo "$(pwd)/src" > ./env/lib/python3.5/site-packages/aiy.pth |
There was a problem hiding this comment.
Just saw the cd above. Forget this comment :)
|
@protovist, shall we wait until after the next image release to merge this, just in case it breaks something? |
|
@RichardBronosky can you rebase with the latest changes we've submitted to the aiyprojects branch? Thanks! |
5 participants
Remove the assumed /home/pi/AIY-projects-python project path. This is
easily done because of the previous cd call changes the CWD to the
project path. This change is needed because of conflicting instructions
in HACKING.md This resolves
#211