Vectorize some netsim, bluetooth and wifi assemble_cve flags#1614
Merged
jemoreira merged 3 commits intogoogle:mainfrom Sep 9, 2025
Merged
Vectorize some netsim, bluetooth and wifi assemble_cve flags#1614jemoreira merged 3 commits intogoogle:mainfrom
jemoreira merged 3 commits intogoogle:mainfrom
Conversation
The flag is overloaded to mean whether a particular device has a wifi card and whether wmediumd and other host side utilities should run. It needs to be vectorized because some targets turn the feature off (auto) via config, but may share an environment with devices that do use it (phone). The (vectorized) --enable_wifi flag now only means that a device has a wifi card. The host side utilities are enabled when at least one device has a wifi card. The name enable_wifi might not be the most appropriate for this functionality, but it's kept for backwards compatibility. Equivalent to ag/I68aad092c36fea5ef1d74597f2eafccf28e1c97e Bug=b/441907863
The flag now means whether a particular device has a bluetooth implementation that relies on the host (netsimd or rootcanal). The old code enabled the host bluetooth functionality even when the flag value was false if netsim_bt was enabled. This behavior is maintained after this change. Equivalent to ag/Icc9f4f7b00dc3df87c810edd2565d2f71ea2af95 Bug=b/441907863
ser-io
approved these changes
Sep 5, 2025
Databean
approved these changes
Sep 5, 2025
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
Databean
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
Member
|
ag/Ice407eb8f3d47a9974ddac861384aca973258890 was reverted in ag/Ia249214153d423daa0a209dc601888d2ccdfc371 to fix b/443309669 |
Databean
requested changes
Sep 5, 2025
Member
Databean
left a comment
Databean
left a comment
There was a problem hiding this comment.
ag/Ice407eb8f3d47a9974ddac861384aca973258890 was reverted in ag/Ia249214153d423daa0a209dc601888d2ccdfc371 to fix b/443309669
Except netsim_args, which is environment specific. Netsim flags determine whether a particular device requires netsim for bt or uwb. The netsim process is started if at least one device requires it. Equivalent to ag/If851c1bde6e8a81e4bdb6f7fffbe43696e22265b Bug=b/441907863
Member
Author
Fixed |
Databean
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commits in this PR are cherrypicks of: