Use abseil logging in allocd_utils #1957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3405691582
approved these changes
Jan 3, 2026
Collaborator
3405691582
left a comment
3405691582
left a comment
There was a problem hiding this comment.
Did you want to split some of the include changes into a separate commit -- in the same pr is okay -- so they'll be separated cleanly when rebasing?
Optional, since the changes are a small delta.
Collaborator
|
Ah, you enabled automerge. No big deal. |
This was missed in google#1955 . Changing the log header additionally caused a new unrelated error, which is also fixed: ``` In file included from allocd/alloc_utils.cpp:16: allocd/alloc_utils.h:28:10: error: module //allocd:alloc_utils does not depend on a module exporting 'cuttlefish/common/libs/fs/shared_fd.h' 28 | #include "cuttlefish/common/libs/fs/shared_fd.h" | ^ 1 error generated. ``` Bug: b/321795781
Databean
force-pushed
the
allocd_utils_abseil_log
branch
from
192b56b to
ef521c2
Compare
Member
Author
|
Thanks for reviewing! Separated into two commits, the first one still additionally removes the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed in #1955 .
Bug: b/321795781