Skip to content

Conversation

@cjreynol
Copy link
Collaborator

@cjreynol cjreynol commented Jan 5, 2026

Move the new metrics_transmitter binary to this package, and trigger metrics transmission based on the presence of the binary.

@cjreynol cjreynol self-assigned this Jan 5, 2026
@cjreynol
Copy link
Collaborator Author

cjreynol commented Jan 5, 2026

Need to rebase this once #1812 merges

@cjreynol cjreynol force-pushed the metrics_package branch 5 times, most recently from 7951b06 to 6e536e3 Compare January 6, 2026 01:14
@cjreynol cjreynol added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Jan 6, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed kokoro:run Run e2e tests. kokoro:force-run Trigger a presubmit build unconditionally. labels Jan 6, 2026
Locating the README text and the check separately from the
`metrics_orchestration` logic, to make it clear those need to be updated
in sync.

Bug: 473601831
@cjreynol cjreynol force-pushed the metrics_package branch 3 times, most recently from e71b509 to 8cfb13d Compare January 6, 2026 02:11
@cjreynol cjreynol added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Jan 6, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed kokoro:run Run e2e tests. kokoro:force-run Trigger a presubmit build unconditionally. labels Jan 6, 2026
Move the `metrics_transmitter` binary to this new package, and use its
existence as the sole check for enabling metrics transmission.

Also, swap to using the full package transmitter path to avoid issues
with the current substitution model.

Bug: 450053679
@cjreynol cjreynol added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Jan 6, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed kokoro:run Run e2e tests. kokoro:force-run Trigger a presubmit build unconditionally. labels Jan 6, 2026
@cjreynol cjreynol marked this pull request as ready for review January 6, 2026 20:04
@cjreynol cjreynol requested a review from Databean January 6, 2026 20:04
@cjreynol cjreynol added this pull request to the merge queue Jan 6, 2026
Merged via the queue into google:main with commit f26648d Jan 6, 2026
22 checks passed
@cjreynol cjreynol deleted the metrics_package branch January 6, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants