-
Notifications
You must be signed in to change notification settings - Fork 324
Migrate AutoCompleteTextViewHolderFactory to compose #2899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jingtang10
merged 7 commits into
google:master
from
LZRS:sdc-compose-autocompletetextview
Dec 23, 2025
Merged
Migrate AutoCompleteTextViewHolderFactory to compose #2899
jingtang10
merged 7 commits into
google:master
from
LZRS:sdc-compose-autocompletetextview
Dec 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0c952a4 to
8d31f4b
Compare
ab0e1e6 to
73146c0
Compare
FikriMilano
requested changes
Nov 26, 2025
...src/main/java/com/google/android/fhir/datacapture/views/compose/MultiAutoCompleteTextItem.kt
Outdated
Show resolved
Hide resolved
...in/java/com/google/android/fhir/datacapture/views/factories/AutoCompleteViewHolderFactory.kt
Show resolved
Hide resolved
FikriMilano
requested changes
Nov 26, 2025
...in/java/com/google/android/fhir/datacapture/views/factories/AutoCompleteViewHolderFactory.kt
Show resolved
Hide resolved
Collaborator
|
pr looks good. thanks. pls add a video. |
Collaborator
Author
|
Before Screen_recording_20251218_154021.mp4After Screen_recording_20251218_154214.mp4 |
FikriMilano
approved these changes
Dec 23, 2025
jingtang10
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2897
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.