Merged
Conversation
LebedevRI
reviewed
Feb 26, 2025
LebedevRI
reviewed
Feb 27, 2025
LebedevRI
reviewed
Feb 27, 2025
Collaborator
|
Yep, something like this should work i suppose. |
LebedevRI
reviewed
Feb 27, 2025
LebedevRI
reviewed
Feb 27, 2025
Collaborator
|
Hm, and the msvc failures seem real, probably need to explicitly cast something in tests from |
Collaborator
|
Looks like more casts are needed :) |
dmah42
reviewed
Feb 28, 2025
Collaborator
|
Hmm, those msvc failure look weird. I don't think this PR can cause them. |
Contributor
Author
I reproduced the failure on my Windows computer. I don’t understand why, but it seems like the failure is caused by my PR. e1eaa52 may help. |
dmah42
reviewed
Mar 3, 2025
dmah42
reviewed
Mar 3, 2025
dmah42
reviewed
Mar 3, 2025
LebedevRI
approved these changes
Mar 12, 2025
Collaborator
|
@EfesX thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1939