Merge pull request #3341 from iwankgb/housekeeping_verbosity_level

iwankgb · web-flow · commit 4496c9483452 · 2023-06-27T17:26:29.000+02:00
Avoid repeated message when not scrapping root container metrics
diff --git a/manager/container.go b/manager/container.go
@@ -482,7 +482,7 @@ func (cd *containerData) nextHousekeepingInterval() time.Duration {
 		stats, err := cd.memoryCache.RecentStats(cd.info.Name, empty, empty, 2)
 		if err != nil {
 			if cd.allowErrorLogging() {
-				klog.Warningf("Failed to get RecentStats(%q) while determining the next housekeeping: %v", cd.info.Name, err)
+				klog.V(4).Infof("Failed to get RecentStats(%q) while determining the next housekeeping: %v", cd.info.Name, err)
 			}
 		} else if len(stats) == 2 {
 			// TODO(vishnuk): Use no processes as a signal.

Original file line number	Diff line number	Diff line change
`@@ -482,7 +482,7 @@ func (cd *containerData) nextHousekeepingInterval() time.Duration {`
`482`	`482`	`stats, err := cd.memoryCache.RecentStats(cd.info.Name, empty, empty, 2)`
`483`	`483`	`if err != nil {`
`484`	`484`	`if cd.allowErrorLogging() {`
`485`		`- klog.Warningf("Failed to get RecentStats(%q) while determining the next housekeeping: %v", cd.info.Name, err)`
	`485`	`+ klog.V(4).Infof("Failed to get RecentStats(%q) while determining the next housekeeping: %v", cd.info.Name, err)`
`486`	`486`	`}`
`487`	`487`	`} else if len(stats) == 2 {`
`488`	`488`	`// TODO(vishnuk): Use no processes as a signal.`