Update the time_point used in Format.PosixConversions #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a `time_point` in the Format.PosixConversions test cases that produces more distinct values for each of the conversion specifiers, which increases the confidence that we are assigning them correctly. Also correct a comment typo in `time_zone_format.cc:ToTM()` while we are here.
derekmauro
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a
time_pointin the Format.PosixConversions test cases that produces more distinct values for each of the conversion specifiers, which increases the confidence that we are assigning them correctly.Also correct a comment typo in
time_zone_format.cc:ToTM()while we are here.