Use LinkedHash(Map|Set) to guarantee deterministic iteration order

PiperOrigin-RevId: 515144252

Author: brad4d

src/com/google/javascript/jscomp/FunctionArgumentInjector.java

@@ -27,7 +27,7 @@
 import com.google.javascript.rhino.IR;
 import com.google.javascript.rhino.Node;
 import com.google.javascript.rhino.Token;
-import java.util.HashSet;
+import java.util.LinkedHashSet;
 import java.util.Map;
 import java.util.Set;
 
@@ -197,7 +197,7 @@ private static String getUniqueAnonymousParameterName(
    */
   Set<String> findModifiedParameters(Node fnNode) {
     ImmutableSet<String> names = getFunctionParameterSet(fnNode);
-    Set<String> unsafeNames = new HashSet<>();
+    Set<String> unsafeNames = new LinkedHashSet<>();
     return findModifiedParameters(fnNode.getLastChild(), names, unsafeNames, false);
   }
 
@@ -406,7 +406,7 @@ private ImmutableSet<String> findParametersReferencedAfterSideEffect(
       ImmutableSet<String> parameters, Node root) {
 
     // TODO(johnlenz): Consider using scope for this.
-    Set<String> locals = new HashSet<>(parameters);
+    Set<String> locals = new LinkedHashSet<>(parameters);
     gatherLocalNames(root, locals);
 
     ReferencedAfterSideEffect collector = new ReferencedAfterSideEffect(
@@ -442,7 +442,7 @@ private class ReferencedAfterSideEffect implements Visitor, Predicate<Node> {
     private final ImmutableSet<String> parameters;
     private final ImmutableSet<String> locals;
     private boolean sideEffectSeen = false;
-    private final Set<String> parametersReferenced = new HashSet<>();
+    private final Set<String> parametersReferenced = new LinkedHashSet<>();
     private int loopsEntered = 0;
 
     ReferencedAfterSideEffect(ImmutableSet<String> parameters, ImmutableSet<String> locals) {

src/com/google/javascript/jscomp/FunctionInjector.java

@@ -31,8 +31,8 @@
 import com.google.javascript.rhino.jstype.JSType;
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.HashSet;
 import java.util.LinkedHashMap;
+import java.util.LinkedHashSet;
 import java.util.Set;
 import org.jspecify.nullness.Nullable;
 
@@ -832,7 +832,7 @@ private boolean callMeetsBlockInliningRequirements(
       boolean hasArgs = !args.isEmpty();
       if (hasArgs) {
         // Limit the inlining
-        Set<String> allNamesToAlias = new HashSet<>(namesToAlias);
+        Set<String> allNamesToAlias = new LinkedHashSet<>(namesToAlias);
         functionArgumentInjector.maybeAddTempsForCallArguments(
             compiler, calleeFn, args, allNamesToAlias, compiler.getCodingConvention());
         if (!allNamesToAlias.isEmpty()) {
@@ -887,7 +887,7 @@ private CanInlineResult canInlineReferenceDirectly(
     boolean hasArgs = !args.isEmpty();
     if (hasArgs) {
       // Limit the inlining
-      Set<String> allNamesToAlias = new HashSet<>(namesToAlias);
+      Set<String> allNamesToAlias = new LinkedHashSet<>(namesToAlias);
       functionArgumentInjector.maybeAddTempsForCallArguments(
           compiler, fnNode, args, allNamesToAlias, compiler.getCodingConvention());
       if (!allNamesToAlias.isEmpty()) {

src/com/google/javascript/jscomp/FunctionToBlockMutator.java

@@ -29,7 +29,7 @@
 import com.google.javascript.rhino.Node;
 import com.google.javascript.rhino.Token;
 import java.util.ArrayList;
-import java.util.HashMap;
+import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
@@ -325,7 +325,7 @@ private Node aliasAndInlineArguments(
 
       // An arg map that will be updated to contain the
       // safe aliases.
-      Map<String, Node> newArgMap = new HashMap<>(argMap);
+      Map<String, Node> newArgMap = new LinkedHashMap<>(argMap);
 
       // Declare the alias in the same order as they
       // are declared.

src/com/google/javascript/jscomp/RenameLabels.java

@@ -24,8 +24,8 @@
 import java.util.ArrayDeque;
 import java.util.ArrayList;
 import java.util.Deque;
-import java.util.HashMap;
-import java.util.HashSet;
+import java.util.LinkedHashMap;
+import java.util.LinkedHashSet;
 import java.util.Map;
 
 /**
@@ -90,8 +90,7 @@ static class DefaultNameSupplier implements Supplier<String> {
     private final NameGenerator nameGenerator;
 
     private DefaultNameSupplier() {
-      this.nameGenerator = new DefaultNameGenerator(
-          new HashSet<String>(), "", null);
+      this.nameGenerator = new DefaultNameGenerator(new LinkedHashSet<String>(), "", null);
     }
 
     @Override
@@ -287,7 +286,7 @@ private static class LabelInfo {
 
 
   private static class LabelNamespace {
-    final Map<String, LabelInfo> renameMap = new HashMap<>();
+    final Map<String, LabelInfo> renameMap = new LinkedHashMap<>();
   }
 
 }