Remove "runtime type check" support.

This feature of the compiler has long been under used and under maintained. At this time we believe our efforts would be better spent elsewhere.

PiperOrigin-RevId: 485375148

Author: concavelenz

BUILD.bazel

@@ -19,6 +19,9 @@ load("//:bazel/typedast.bzl", "typedast")
 load("@com_github_johnynek_bazel_jar_jar//:jar_jar.bzl", "jar_jar")
 load("@google_bazel_common//testing:test_defs.bzl", "gen_java_tests")
 
+# Produce an unshaded export jar based on :compiler_lib
+load("@rules_jvm_external//:defs.bzl", "java_export")
+
 package(licenses = ["notice"])
 
 filegroup(
@@ -81,16 +84,15 @@ java_binary(
     runtime_deps = [":compiler_lib"],
 )
 
-# Produce an unshaded export jar based on :compiler_lib
-load("@rules_jvm_external//:defs.bzl", "java_export")
 version = "$(COMPILER_VERSION)" or "1.0-SNAPSHOT"
+
 java_export(
     name = "compiler_unshaded",
     maven_coordinates = "com.google.javascript:closure-compiler-unshaded:{0}".format(version),
+    pom_template = "maven/closure-compiler-unshaded.pom.xml.tpl",
     runtime_deps = [
         "//:compiler_lib",
     ],
-    pom_template = "maven/closure-compiler-unshaded.pom.xml.tpl"
 )
 
 java_binary(
@@ -114,7 +116,6 @@ java_library(
     name = "compiler_lib",
     resources = [
         "src/com/google/javascript/jscomp/js/polyfills.txt",
-        "src/com/google/javascript/jscomp/js/runtime_type_check.js",
         ":runtime_lib_typedast_srcs",
         ":runtime_libs_typedast",
     ],
@@ -132,7 +133,6 @@ filegroup(
     srcs = glob(
         ["src/com/google/javascript/jscomp/js/**/*.js"],
         exclude = [
-            "src/com/google/javascript/jscomp/js/runtime_type_check.js",  # TODO(b/192503189) Add this when we can fix the compile errors.
             "src/com/google/javascript/jscomp/js/build_polyfill_table.js",
         ],
     ),
@@ -185,9 +185,9 @@ oss_java_library(
             "@com_google_errorprone_error_prone_annotations",
             "@com_google_guava_failureaccess//jar",
             "@com_google_guava_guava//jar",
-            "@maven//:com_google_protobuf_protobuf_java",
             "@com_google_re2j_re2j",
             "@google_bazel_common//third_party/java/auto:value",
+            "@maven//:com_google_protobuf_protobuf_java",
             "@org_apache_ant_ant",
             "@org_jspecify_jspecify",
         ],
@@ -250,7 +250,6 @@ gen_java_tests(
         "@com_google_guava_guava//jar",
         "@com_google_guava_guava_testlib//jar",
         "@com_google_jimfs_jimfs",
-        "@maven//:com_google_protobuf_protobuf_java",
         "@com_google_re2j_re2j",
         "@com_google_truth_extensions_truth_liteproto_extension",
         "@com_google_truth_extensions_truth_proto_extension",
@@ -259,6 +258,7 @@ gen_java_tests(
         "@google_bazel_common//third_party/java/mockito",
         "@google_bazel_common//third_party/java/truth",
         "@io_github_java_diff_utils_java_diff_utils",
+        "@maven//:com_google_protobuf_protobuf_java",
         "@org_jspecify_jspecify",
     ],
 )

src/com/google/javascript/jscomp/CommandLineRunner.java

@@ -812,7 +812,7 @@ private static class Flags {
         usage =
             "Force injection of named runtime libraries. "
                 + "The format is <name> where <name> is the name of a runtime library. "
-                + "Possible libraries include: base, es6_runtime, runtime_type_check")
+                + "Possible libraries include: base, es6_runtime")
     private List<String> forceInjectLibraries = new ArrayList<>();
 
     @Option(

src/com/google/javascript/jscomp/CompilerOptions.java

@@ -702,14 +702,6 @@ public boolean shouldRunReplaceMessagesForChrome() {
     }
   }
 
-  /** Inserts run-time type assertions for debugging. */
-  boolean runtimeTypeCheck;
-
-  /**
-   * A JS function to be used for logging run-time type assertion failures. It will be passed the
-   * warning as a string and the faulty expression as arguments.
-   */
-  @Nullable String runtimeTypeCheckLogFunction;
 
   /** A CodingConvention to use during the compile. */
   private CodingConvention codingConvention;
@@ -1365,8 +1357,7 @@ public CompilerOptions() {
     nameGenerator = new DefaultNameGenerator();
 
     // Alterations
-    runtimeTypeCheck = false;
-    runtimeTypeCheckLogFunction = null;
+
     syntheticBlockStartMarker = null;
     syntheticBlockEndMarker = null;
     locale = null;
@@ -1657,20 +1648,6 @@ public boolean shouldColorizeErrorOutput() {
     return colorizeErrorOutput;
   }
 
-  /**
-   * Enable run-time type checking, which adds JS type assertions for debugging.
-   *
-   * @param logFunction A JS function to be used for logging run-time type assertion failures.
-   */
-  public void enableRuntimeTypeCheck(String logFunction) {
-    this.runtimeTypeCheck = true;
-    this.runtimeTypeCheckLogFunction = logFunction;
-  }
-
-  public void disableRuntimeTypeCheck() {
-    this.runtimeTypeCheck = false;
-  }
-
   public void setChecksOnly(boolean checksOnly) {
     this.checksOnly = checksOnly;
   }
@@ -2294,13 +2271,6 @@ public void setExportTestFunctions(boolean exportTestFunctions) {
     this.exportTestFunctions = exportTestFunctions;
   }
 
-  public void setRuntimeTypeCheck(boolean runtimeTypeCheck) {
-    this.runtimeTypeCheck = runtimeTypeCheck;
-  }
-
-  public void setRuntimeTypeCheckLogFunction(String runtimeTypeCheckLogFunction) {
-    this.runtimeTypeCheckLogFunction = runtimeTypeCheckLogFunction;
-  }
 
   public void setSyntheticBlockStartMarker(String syntheticBlockStartMarker) {
     this.syntheticBlockStartMarker = syntheticBlockStartMarker;
@@ -2947,8 +2917,6 @@ public String toString() {
         .add("reserveRawExports", reserveRawExports)
         .add("rewriteFunctionExpressions", rewriteFunctionExpressions)
         .add("rewritePolyfills", rewritePolyfills)
-        .add("runtimeTypeCheckLogFunction", runtimeTypeCheckLogFunction)
-        .add("runtimeTypeCheck", runtimeTypeCheck)
         .add("rewriteModulesBeforeTypechecking", rewriteModulesBeforeTypechecking)
         .add("skipNonTranspilationPasses", skipNonTranspilationPasses)
         .add("smartNameRemoval", smartNameRemoval)

src/com/google/javascript/jscomp/DefaultPassConfig.java

@@ -490,15 +490,6 @@ protected PassListBuilder getChecks() {
       checks.maybeAdd(externExports);
     }
 
-    if (options.runtimeTypeCheck) {
-      // RuntimeTypeCheck depends on the AST being normalized. We immediately mark the AST
-      // unnormalized as subsequent passes may produce unnormalized code.
-      // TODO(b/197349249): always run normalize here.
-      checks.maybeAdd(normalize);
-      checks.maybeAdd(runtimeTypeCheck);
-      checks.maybeAdd(markUnnormalized);
-    }
-
     if (!options.checksOnly) {
       checks.maybeAdd(removeWeakSources);
     }
@@ -2070,16 +2061,6 @@ public void process(Node externs, Node jsRoot) {
           .setInternalFactory(ConstParamCheck::new)
           .build();
 
-  /** Inserts run-time type assertions for debugging. */
-  private final PassFactory runtimeTypeCheck =
-      PassFactory.builder()
-          .setName(PassNames.RUNTIME_TYPE_CHECK)
-          .setInternalFactory(
-              (compiler) -> new RuntimeTypeCheck(compiler, options.runtimeTypeCheckLogFunction))
-          // TODO(bradfordcsmith): Drop support for this pass.
-          // It's never been updated to handle ES2016+ code, because it isn't worth the effort.
-          .build();
-
   /** Generates unique ids. */
   private final PassFactory replaceIdGenerators =
       PassFactory.builder()

src/com/google/javascript/jscomp/InjectRuntimeLibraries.java

@@ -18,20 +18,14 @@
 import com.google.javascript.rhino.Node;
 
 /**
- * Adds runtime libraries to the beginning of the AST. The libraries for runtime typechecking are
- * added, if needed, as well as any other libraries explicitly requested via the {@link
- * CompilerOptions#forceLibraryInjection} field.
+ * Adds runtime libraries to the beginning of the AST. Any libraries explicitly requested via the
+ * {@link CompilerOptions#forceLibraryInjection} field.
  *
  * <p>TODO(b/120486392): merge this pass with {@link InjectTranspilationRuntimeLibraries}.
  */
 class InjectRuntimeLibraries implements CompilerPass {
   private final AbstractCompiler compiler;
   private final Stage stage;
-  // The runtime type check library code is special in that it is the only library that should be
-  // injected before typechecking. All other library code is expected to be injected during the
-  // optimization phase. This is because runtime typechecking is incompatible with a binary reading
-  // from precompiled TypedASTs.
-  private static final String RUNTIME_TYPE_CHECK_LIB = "runtime_type_check";
 
   private enum Stage {
     CHECKS,
@@ -49,7 +43,6 @@ public void process(Node externs, Node root) {
     CompilerOptions options = compiler.getOptions();
     switch (this.stage) {
       case CHECKS:
-        injectCheckLibraries(options);
         return;
       case OPTIMIZATIONS:
         injectOptimizationsLibraries(options);
@@ -58,18 +51,9 @@ public void process(Node externs, Node root) {
     throw new AssertionError();
   }
 
-  private void injectCheckLibraries(CompilerOptions options) {
-    if (options.runtimeTypeCheck
-        || options.forceLibraryInjection.contains(RUNTIME_TYPE_CHECK_LIB)) {
-      compiler.ensureLibraryInjected(RUNTIME_TYPE_CHECK_LIB, true);
-    }
-  }
-
   private void injectOptimizationsLibraries(CompilerOptions options) {
     for (String forced : options.forceLibraryInjection) {
-      if (!forced.equals(RUNTIME_TYPE_CHECK_LIB)) {
-        compiler.ensureLibraryInjected(forced, true);
-      }
+      compiler.ensureLibraryInjected(forced, true);
     }
   }
 

src/com/google/javascript/jscomp/PassNames.java

@@ -88,7 +88,6 @@ public final class PassNames {
   public static final String RESOLVE_TYPES = "resolveTypes";
   public static final String REWRITE_FUNCTION_EXPRESSIONS = "rewriteFunctionExpressions";
   public static final String RENAME_PROPERTIES = "renameProperties";
-  public static final String RUNTIME_TYPE_CHECK = "runtimeTypeCheck";
   public static final String STRIP_SIDE_EFFECT_PROTECTION = "stripSideEffectProtection";
   public static final String WIZ_PASS = "wizPass";
   public static final String PARENTHESIZE_FUNCTIONS_IN_CHUNKS = "parenthesizeFunctionsInChunks";