Internal change

PiperOrigin-RevId: 515370620

Author: Closure Team

src/com/google/javascript/jscomp/CheckConformance.java

@@ -287,6 +287,8 @@ private static void removeDuplicates(Requirement.Builder requirement) {
           return new ConformanceRules.BannedDependencyRegex(compiler, requirement);
         case BANNED_ENHANCE:
           return new ConformanceRules.BannedEnhance(compiler, requirement);
+        case BANNED_MODS_REGEX:
+          return new ConformanceRules.BannedModsRegex(compiler, requirement);
         case BANNED_NAME:
         case BANNED_NAME_CALL:
           return new ConformanceRules.BannedName(compiler, requirement);

src/com/google/javascript/jscomp/ConformanceRules.java

@@ -1927,6 +1927,49 @@ public final Precondition getPrecondition() {
     }
   }
 
+  /** Checks that file does not include an @mods annotation for a banned namespace regex. */
+  public static final class BannedModsRegex extends AbstractRule {
+    private final Pattern bannedModsRegex;
+
+    public BannedModsRegex(AbstractCompiler compiler, Requirement requirement)
+        throws InvalidRequirementSpec {
+      super(compiler, requirement);
+
+      List<String> bannedModsRegexList = requirement.getValueList();
+      if (requirement.getValueCount() == 0) {
+        throw new InvalidRequirementSpec("missing value");
+      }
+      bannedModsRegex = buildPattern(bannedModsRegexList);
+    }
+
+    @Override
+    protected ConformanceResult checkConformance(NodeTraversal t, Node n) {
+      JSDocInfo docInfo = n.getJSDocInfo();
+
+      if (docInfo == null || !docInfo.hasMods()) {
+        return ConformanceResult.CONFORMANCE;
+      }
+
+      if (bannedModsRegex.matcher(docInfo.getMods()).find()) {
+        return ConformanceResult.VIOLATION;
+      }
+      return ConformanceResult.CONFORMANCE;
+    }
+
+    private static final Precondition IS_SCRIPT_NODE =
+        new Precondition() {
+          @Override
+          public boolean shouldCheck(Node n) {
+            return n.isScript();
+          }
+        };
+
+    @Override
+    public final Precondition getPrecondition() {
+      return IS_SCRIPT_NODE;
+    }
+  }
+
   private static final QualifiedName GOOG_DOM = QualifiedName.of("goog.dom");
   private static final QualifiedName GOOG_DOM_TAGNAME = QualifiedName.of("goog.dom.TagName");
 

src/com/google/javascript/jscomp/conformance/conformance.proto

@@ -178,6 +178,9 @@ message Requirement {
     // based on the passed in regular expression value.
     // example: value: ".*oo.*" in "foobar" would match.
     BANNED_STRING_REGEX = 17;
+
+    // A banned @mods annotation using regular expressions.
+    BANNED_MODS_REGEX = 18;
   }
 
   enum TypeMatchingStrategy {

test/com/google/javascript/jscomp/CheckConformanceTest.java

@@ -660,6 +660,27 @@ public void testBannedEnhance() {
     testNoWarning(allow2);
   }
 
+  @Test
+  public void testBannedModsRegex() {
+    configuration =
+        "requirement: {\n"
+            + "  type: BANNED_MODS_REGEX\n"
+            + "  value: '.+_bar$'\n"
+            + "  error_message: 'Modding namespaces ending in _bar is NOT allowed.'\n"
+            + "}";
+    String violationMessage = "Violation: Modding namespaces ending in _bar is NOT allowed.";
+
+    String ban = lines("/**", " * @mods {ns.foo_bar}", " * @modName {ns.foo_bar_baz}", " */");
+    testWarning(ban, CheckConformance.CONFORMANCE_VIOLATION, violationMessage);
+
+    String allow1 = lines("/**", " * @mods {ns.foo}", " * @modName {ns.foo_bar}", " */");
+    testNoWarning(allow1);
+
+    String allow2 =
+        lines("/**", " * @fileoverview no enhance annotation should always pass.", " */");
+    testNoWarning(allow2);
+  }
+
   @Test
   public void testBannedNameCall() {
     configuration =