Remove unnecessary isSubtypeOf check in InvocationTemplateTypeMatcher

I suspect the intent of the isSubtypeOf check was to mainly save time and avoid unnecessary matchTemplateTypesRecursive calls.

In practice, it seems cheaper to just do the recursive call. Subtype checks are especially costly for structural types, where we recursively call isSubtypeOf on each property.

PiperOrigin-RevId: 515401346

Author: lauraharker

src/com/google/javascript/jscomp/InvocationTemplateTypeMatcher.java

@@ -187,21 +187,16 @@ private void matchTemplateTypesRecursive(JSType paramType, JSType argType) {
         return;
       }
 
-      ObjectType referencedParamType = templatizedParamType.getReferencedType();
       JSType argObjectType = argType.restrictByNotNullOrUndefined().collapseUnion();
+      // Resolve any template types in common between the argument type and parameter type
+      TemplateTypeMap paramTypeMap = paramType.getTemplateTypeMap();
 
-      if (argObjectType.isSubtypeOf(referencedParamType)) {
-        // If the argument type is a subtype of the parameter type, resolve any
-        // template types amongst their templatized types.
-        TemplateTypeMap paramTypeMap = paramType.getTemplateTypeMap();
-
-        ImmutableList<TemplateType> keys = paramTypeMap.getTemplateKeys();
-        TemplateTypeMap argTypeMap = argObjectType.getTemplateTypeMap();
-        for (int index = keys.size() - keyCount; index < keys.size(); index++) {
-          TemplateType key = keys.get(index);
-          this.matchTemplateTypesRecursive(
-              paramTypeMap.getResolvedTemplateType(key), argTypeMap.getResolvedTemplateType(key));
-        }
+      ImmutableList<TemplateType> keys = paramTypeMap.getTemplateKeys();
+      TemplateTypeMap argTypeMap = argObjectType.getTemplateTypeMap();
+      for (int index = keys.size() - keyCount; index < keys.size(); index++) {
+        TemplateType key = keys.get(index);
+        this.matchTemplateTypesRecursive(
+            paramTypeMap.getResolvedTemplateType(key), argTypeMap.getResolvedTemplateType(key));
       }
     }
   }