Never suppress unrecognized type errors for goog.provide/goog.module namespaces

Currently if running the compiler in a mode that sorts or prunes unused dependencies, all goog.module & goog.provide namespaces are "forward declared", so the compiler won't report unrecognized type errors for those namespaces. This is unnecessary and confusing so we're removing it.

PiperOrigin-RevId: 515375398

Author: lauraharker

src/com/google/javascript/jscomp/Compiler.java

@@ -2044,14 +2044,6 @@ void orderInputs() {
     // Check if the sources need to be re-ordered.
     boolean staleInputs = false;
     if (options.getDependencyOptions().needsManagement()) {
-      for (CompilerInput input : moduleGraph.getAllInputs()) {
-        // Forward-declare all the provided types, so that they
-        // are not flagged even if they are dropped from the process.
-        for (String provide : input.getProvides()) {
-          forwardDeclareType(provide);
-        }
-      }
-
       try {
         moduleGraph.manageDependencies(this, options.getDependencyOptions());
         staleInputs = true;

test/com/google/javascript/jscomp/CommandLineRunnerTest.java

@@ -1326,34 +1326,6 @@ public void testDependencySortingWhitespaceMode() {
         });
   }
 
-  @Test
-  public void testForwardDeclareDroppedTypes() {
-    args.add("--dependency_mode=PRUNE_LEGACY");
-
-    args.add("--warning_level=VERBOSE");
-    test(
-        new String[] {
-          lines(
-              "/** @externs */", //
-              new TestExternsBuilder().addClosureExterns().build()),
-          "goog.require('beer');",
-          "goog.provide('beer'); /** @param {Scotch} x */ function f(x) {}",
-          "goog.provide('Scotch'); var x = 3;"
-        },
-        new String[] {"var beer = {}; function f(a) {}", ""});
-
-    test(
-        new String[] {
-          lines(
-              "/** @externs */", //
-              new TestExternsBuilder().addClosureExterns().build()),
-          "goog.require('beer');",
-          "goog.provide('beer'); /** @param {Scotch} x */ function f(x) {}"
-        },
-        new String[] {"var beer = {}; function f(a) {}", ""},
-        RhinoErrorReporter.UNRECOGNIZED_TYPE_ERROR);
-  }
-
   @Test
   public void testOnlyClosureDependenciesEmptyEntryPoints() throws Exception {
     // Prevents this from trying to load externs.zip