Update issue type and component for VRP uploaded bugs#4580
Merged
jonathanmetzman merged 1 commit intogoogle:masterfrom Feb 5, 2025
Merged
Update issue type and component for VRP uploaded bugs#4580jonathanmetzman merged 1 commit intogoogle:masterfrom
jonathanmetzman merged 1 commit intogoogle:masterfrom
Conversation
|
|
||
| # These bugs were filed via the direct upload and hence specific to the | ||
| # google issue tracker. | ||
| if hasattr(issue, |
Collaborator
There was a problem hiding this comment.
when would it not have component_id?
You can replace this with getattr(issue, 'component_id', None) == VRP_UPLOAD_COMPONENT_ID.
Contributor
Author
There was a problem hiding this comment.
i believe an issue wouldnt have component_id for non google issue tracker (monorail, jira)
but ooh thank you done!
pgrace-google
force-pushed
the
type_change
branch
from
43609e4 to
00584fb
Compare
pgrace-google
commented
Jan 20, 2025
Contributor
Author
pgrace-google
left a comment
pgrace-google
left a comment
There was a problem hiding this comment.
first of all, sorry i am like in and out here - its probably super annoying for you to review to try to remember what i was trying to do. i am going to finish this finally though - finally prioritized
|
|
||
| # These bugs were filed via the direct upload and hence specific to the | ||
| # google issue tracker. | ||
| if hasattr(issue, |
Contributor
Author
There was a problem hiding this comment.
i believe an issue wouldnt have component_id for non google issue tracker (monorail, jira)
but ooh thank you done!
pgrace-google
requested review from
hogo6002,
jonathanmetzman and
vitorguidi
and removed request for
hogo6002
pgrace-google
force-pushed
the
type_change
branch
from
00584fb to
009393f
Compare
Contributor
Author
|
(just rebasing) |
pgrace-google
added a commit
to pgrace-google/clusterfuzz
that referenced
this pull request
Feb 5, 2025
pgrace-google
added a commit
that referenced
this pull request
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Question 0: dont review this yet im running tests just to make sure its right
Question 1: i imagine there is a better place to put the component ids, but i havent been able to find it. where is it??