Non linux utask queueing #4904
Open
Non linux utask queueing #4904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's a summary of the changes: I modified the task queuing logic for `utask_main` tasks. Previously, all `utask_main` tasks were sent to the `UTASK_MAIN_QUEUE`, which was problematic for non-Linux jobs that need to run on specific platforms. I've updated `add_utask_main` to check the job's platform. If the platform isn't Linux, it now uses `queue_for_job` with a new `force_true_queue` parameter to find the correct, platform-specific queue. This ensures that non-Linux `utask_main` tasks are routed to the appropriate bots. Linux jobs will continue to use the `UTASK_MAIN_QUEUE` as before. Finally, I added tests to verify the new queuing logic.
…eue. I modified the task queuing logic for `utask_main` tasks. Previously, all `utask_main` tasks were sent to the `UTASK_MAIN_QUEUE`, which was problematic for non-Linux jobs that need to run on bots with the correct platform. Now, I've updated `add_utask_main` to get the platform from the environment and use `queue_for_platform` to get the correct, platform-specific queue. This ensures that non-Linux `utask_main` tasks are routed to the correct bots. Linux jobs will continue to use the `UTASK_MAIN_QUEUE` as before. I also updated the tests to verify the new queuing logic.
javanlacerda
approved these changes
Aug 8, 2025
| if platform.upper() == 'LINUX': | ||
| queue = UTASK_MAIN_QUEUE | ||
| else: | ||
| thread_multiplier = environment.get_value('THREAD_MULTIPLIER') |
|
This pull request has not had any activity for 60 days and will be automatically closed in two weeks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it possible to preprocess e.g. mac tasks on linux but then execute utask_main on the mac pool.