Refactor reproduce #4988
Refactor reproduce #4988
Conversation
|
|
||
| # Make fuzzer executable. | ||
| os.chmod(fuzzer_path, 0o750) | ||
| os.chmod(fuzzer_path, _EXECUTABLE_PERMISSIONS) |
| upload_url: str): | ||
| def archive_testcase_and_dependencies_in_gcs( | ||
| resource_list, | ||
| testcase_path: str, # pylint: disable=line-too-long |
There was a problem hiding this comment.
I think this line-too-long can be removed. ?
There was a problem hiding this comment.
You're right. I've removed and runned lint again. Thanks!
|
Could you provide a quick evidence of these changes working? |
|
|
||
| try: | ||
| _, testcase_file_path = _get_testcase_file_and_path(testcase) | ||
| if testcase.minimized_keys and testcase.minimized_keys != 'NA': |
There was a problem hiding this comment.
Why not use the _is_testcase_minimized method here?
|
|
||
| def set_local_log_only(): | ||
| """Force logs to be local-only.""" | ||
| set_value('LOG_TO_GCP', '') |
There was a problem hiding this comment.
Please, add a short comment explaining that we set this to an empty string because currently the logs module does not correctly evaluate env vars (i.e., 'false' is evaluated to true).
| return archived, absolute_filename, zip_filename | ||
|
|
||
|
|
||
| def setup_local_testcase(testcase: data_types.Testcase) -> str | None: |
There was a problem hiding this comment.
There is a preprocess_setup_testcase method which you don't define a local version. Is there a reason?
Also, I noticed that in this function, it sets the APP_ARGS based on the return of _get_application_arguments, which you do only in the reproduce module. Maybe you could try to do it here instead and using this helper method?
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| """Tests for the reproduce butler.""" |
4 participants
This PR is a follow-up to #4976, addressing the feedback and discussions from the original review. The primary focus is on refactoring and code quality improvements.
(Note: This PR involves a significant amount of code being moved to more appropriate modules.)
Quick summary:
setup.pymodule--local-loggingflag tobutlerto enable convenient local log output during development.minimized_keysduring setup.