-
Notifications
You must be signed in to change notification settings - Fork 1.9k
RAII chapter for idiomatic rust #2820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GlenDC
wants to merge
14
commits into
main
Choose a base branch
from
raii
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
39ae8f6
initial version of the raii chapters for idiomatic rust
GlenDC f4269b7
apply dprint fmt
GlenDC bb88a79
fix build (en) step: scopeguard crate import
GlenDC 5a4838e
integrate feedback of first reviews (RAII)
GlenDC d804144
add new `RAII` intro segment
GlenDC 5c2ec8c
further improvements to RAII intro chapter
GlenDC 0baa990
fix typo
GlenDC 9fa819a
improve RAII intro segment further based on Luca's feedbacl
GlenDC 4ebb43f
apply feedback RAII and rewrite; draft 1
GlenDC 42a4237
improve drop bomb code example
GlenDC 2923cf3
prepare raii chapter for next reviews
GlenDC 48c5baa
fix raii drop bomb example
GlenDC cc5f3b5
address feedback 1/2 of @randomPoison
GlenDC 55e4753
address @randomPoison feedback 2/2
GlenDC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,113 @@ | ||
--- | ||
minutes: 30 | ||
--- | ||
|
||
# RAII: `Drop` trait | ||
|
||
RAII (**R**esource **A**cquisition **I**s **I**nitialization) ties the lifetime | ||
of a resource to the lifetime of a value. | ||
|
||
[Rust uses RAII to manage memory](https://doc.rust-lang.org/rust-by-example/scope/raii.html), | ||
and the `Drop` trait allows you to extend this to other resources, such as file | ||
descriptors or locks. | ||
|
||
```rust,editable | ||
pub struct File(std::os::fd::RawFd); | ||
|
||
impl File { | ||
pub fn open(path: &str) -> Result<Self, std::io::Error> { | ||
// [...] | ||
Ok(Self(0)) | ||
} | ||
|
||
pub fn read_to_end(&mut self) -> Result<Vec<u8>, std::io::Error> { | ||
// [...] | ||
Ok(b"example".to_vec()) | ||
} | ||
|
||
pub fn close(self) -> Result<(), std::io::Error> { | ||
// [...] | ||
Ok(()) | ||
} | ||
} | ||
|
||
fn main() -> Result<(), std::io::Error> { | ||
let mut file = File::open("example.txt")?; | ||
println!("content: {:?}", file.read_to_end()?); | ||
Ok(()) | ||
} | ||
``` | ||
|
||
<details> | ||
|
||
- This example shows how easy it is to forget releasing a file descriptor when | ||
managing it manually. The code as written does not call `file.close()`. Did | ||
anyone in the class notice? | ||
|
||
- To release the file descriptor correctly, `file.close()` must be called after | ||
the last use — and also in early-return paths in case of errors. | ||
|
||
- Instead of relying on the user to call `close()`, we can implement the `Drop` | ||
trait to release the resource automatically. This ties cleanup to the lifetime | ||
of the `File` value. | ||
|
||
```rust,compile_fail | ||
impl Drop for File { | ||
fn drop(&mut self) { | ||
println!("release file descriptor automatically"); | ||
} | ||
} | ||
``` | ||
|
||
- Note that `Drop::drop` cannot return errors. Any fallible logic must be | ||
handled internally or ignored. In the standard library, errors returned while | ||
closing an owned file descriptor during `Drop` are silently discarded: | ||
<https://doc.rust-lang.org/src/std/os/fd/owned.rs.html#169-196> | ||
|
||
- If both `drop()` and `close()` exist, the file descriptor may be released | ||
twice. To avoid this, remove `close()` and rely solely on `Drop`. | ||
|
||
- When is `Drop::drop` called? | ||
|
||
Normally, when the `file` variable in `main` goes out of scope (either on | ||
return or due to a panic), `drop()` is called automatically. | ||
|
||
If the file is moved into another function, for example `read_all()`, the | ||
value is dropped when that function returns — not in `main`. | ||
|
||
In contrast, C++ runs destructors in the original scope even for moved-from | ||
values. | ||
|
||
- The same mechanism powers `std::mem::drop`: | ||
|
||
```rust | ||
pub fn drop<T>(_x: T) {} | ||
``` | ||
|
||
You can use it to force early destruction of a value before its natural end of | ||
scope. | ||
|
||
- Insert `panic!("oops")` at the start of `read_to_end()` to show that `drop()` | ||
still runs during unwinding. Rust guarantees this unless the panic strategy is | ||
set to `abort`. | ||
GlenDC marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
- There are cases where destructors will not run: | ||
- If a destructor itself panics during unwinding, the program aborts | ||
immediately. | ||
- If the program exits with `std::process::exit()` or is compiled with the | ||
`abort` panic strategy, destructors are skipped. | ||
|
||
### More to Explore | ||
|
||
The `Drop` trait has another important limitation: it is not `async`. | ||
|
||
This means you cannot `await` inside a destructor, which is often needed when | ||
cleaning up asynchronous resources like sockets, database connections, or tasks | ||
that must signal completion to another system. | ||
|
||
- Learn more: | ||
<https://rust-lang.github.io/async-fundamentals-initiative/roadmap/async_drop.html> | ||
- There is an experimental `AsyncDrop` trait available on nightly: | ||
<https://doc.rust-lang.org/nightly/std/future/trait.AsyncDrop.html> | ||
|
||
</details> |
123 changes: 123 additions & 0 deletions
123
src/idiomatic/leveraging-the-type-system/raii/drop_bomb.md
GlenDC marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,123 @@ | ||
# Drop Bombs: Enforcing API Correctness | ||
|
||
Use `Drop` to enforce invariants and detect incorrect API usage. A "drop bomb" | ||
panics if a value is dropped without being explicitly finalized. | ||
|
||
This pattern is often used when the finalizing operation (like `commit()` or | ||
`rollback()`) needs to return a `Result`, which cannot be done from `Drop`. | ||
|
||
```rust,editable | ||
use std::io::{self, Write}; | ||
|
||
struct Transaction { | ||
active: bool, | ||
} | ||
|
||
impl Transaction { | ||
/// Begin a [`Transaction`]. | ||
/// | ||
/// ## Panics | ||
/// | ||
/// Panics if the transaction is dropped without | ||
/// calling [`Self::commit`] or [`Self::rollback`]. | ||
fn start() -> Self { | ||
Self { active: true } | ||
} | ||
|
||
fn commit(mut self) -> io::Result<()> { | ||
writeln!(io::stdout(), "COMMIT")?; | ||
self.active = false; | ||
Ok(()) | ||
} | ||
|
||
fn rollback(mut self) -> io::Result<()> { | ||
writeln!(io::stdout(), "ROLLBACK")?; | ||
self.active = false; | ||
Ok(()) | ||
} | ||
} | ||
|
||
impl Drop for Transaction { | ||
fn drop(&mut self) { | ||
if self.active { | ||
panic!("Transaction dropped without commit or rollback!"); | ||
} | ||
} | ||
} | ||
|
||
fn main() -> io::Result<()> { | ||
let tx = Transaction::start(); | ||
|
||
if some_condition() { | ||
tx.commit()?; | ||
} else { | ||
tx.rollback()?; | ||
} | ||
|
||
// Uncomment to see the panic: | ||
// let tx2 = Transaction::start(); | ||
|
||
Ok(()) | ||
} | ||
|
||
fn some_condition() -> bool { | ||
// [...] | ||
true | ||
} | ||
``` | ||
|
||
<details> | ||
|
||
- This pattern ensures that a value like `Transaction` cannot be silently | ||
dropped in an unfinished state. The destructor panics if neither `commit()` | ||
nor `rollback()` has been called. | ||
|
||
- A common reason to use this pattern is when cleanup cannot be done in `Drop`, | ||
either because it is fallible or asynchronous. | ||
|
||
- This pattern is appropriate even in public APIs. It can help users catch bugs | ||
early when they forget to explicitly finalize a transactional object. | ||
|
||
- If a value can be safely cleaned up in `Drop`, consider falling back to that | ||
behavior in Release mode and panicking only in Debug. This decision should be | ||
made based on the guarantees your API provides. | ||
|
||
- Panicking in Release builds is a valid choice if silent misuse could lead to | ||
serious correctness issues or security concerns. | ||
|
||
## Additional Patterns | ||
|
||
- [`Option<T>` with `.take()`](https://doc.rust-lang.org/std/option/enum.Option.html#method.take): | ||
A common pattern inside `Drop` to move out internal values and prevent double | ||
drops. | ||
|
||
```rust,compile_fail | ||
impl Drop for MyResource { | ||
fn drop(&mut self) { | ||
if let Some(handle) = self.handle.take() { | ||
// do cleanup with handle | ||
} | ||
} | ||
} | ||
``` | ||
|
||
- [`ManuallyDrop`](https://doc.rust-lang.org/std/mem/struct.ManuallyDrop.html): | ||
Prevents automatic destruction and gives full manual control. Requires | ||
`unsafe`, so only use when strictly necessary. | ||
|
||
- [`drop_bomb` crate](https://docs.rs/drop_bomb/latest/drop_bomb/): A small | ||
utility that panics if dropped unless explicitly defused with `.defuse()`. | ||
Comes with a `DebugDropBomb` variant that only activates in debug builds. | ||
|
||
- In some systems, a value must be finalized by a specific API before it is | ||
dropped. | ||
|
||
For example, an `SshConnection` might need to be deregistered from an | ||
`SshServer` before being dropped, or the program panics. This helps catch | ||
programming mistakes during development and enforces correct teardown at | ||
runtime. | ||
|
||
See a working example in | ||
[the Rust playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=3223f5fa5e821cd32461c3af7162cd55). | ||
|
||
</details> |
GlenDC marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,131 @@ | ||
# Mutex | ||
|
||
In earlier examples, RAII was used to manage concrete resources like file | ||
descriptors. With a `Mutex`, the resource is more abstract: exclusive access to | ||
a value. | ||
|
||
Rust models this using a `MutexGuard`, which ties access to a critical section | ||
to the lifetime of a value on the stack. | ||
|
||
```rust | ||
#[derive(Debug)] | ||
struct Mutex<T> { | ||
value: std::cell::UnsafeCell<T>, | ||
// [...] | ||
} | ||
|
||
#[derive(Debug)] | ||
struct MutexGuard<'a, T> { | ||
value: &'a mut T, | ||
// [...] | ||
} | ||
|
||
impl<T> Mutex<T> { | ||
fn new(value: T) -> Self { | ||
Self { | ||
value: std::cell::UnsafeCell::new(value), | ||
// [...] | ||
} | ||
} | ||
|
||
fn lock(&self) -> MutexGuard<T> { | ||
// [...] | ||
let value = unsafe { &mut *self.value.get() }; | ||
MutexGuard { value } | ||
} | ||
} | ||
|
||
impl<'a, T> std::ops::Deref for MutexGuard<'a, T> { | ||
type Target = T; | ||
fn deref(&self) -> &T { | ||
self.value | ||
} | ||
} | ||
|
||
impl<'a, T> std::ops::DerefMut for MutexGuard<'a, T> { | ||
fn deref_mut(&mut self) -> &mut T { | ||
self.value | ||
} | ||
} | ||
GlenDC marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
impl<'a, T> Drop for MutexGuard<'a, T> { | ||
fn drop(&mut self) { | ||
// [...] | ||
println!("drop MutexGuard"); | ||
} | ||
GlenDC marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
fn main() { | ||
let m = Mutex::new(vec![1, 2, 3]); | ||
|
||
let mut guard = m.lock(); | ||
guard.push(4); | ||
guard.push(5); | ||
println!("{guard:?}"); | ||
} | ||
``` | ||
|
||
<details> | ||
|
||
- A `Mutex` controls exclusive access to a value. Unlike earlier RAII examples, | ||
the resource here is not external but logical: the right to mutate shared | ||
data. | ||
|
||
- This right is represented by a `MutexGuard`. Only one can exist at a time. | ||
While it lives, it provides `&mut T` access — enforced using `UnsafeCell`. | ||
|
||
- Although `lock()` takes `&self`, it returns a `MutexGuard` with mutable | ||
access. This is possible through interior mutability: a common pattern for | ||
safe shared-state mutation. | ||
|
||
- `MutexGuard` implements `Deref` and `DerefMut`, making access ergonomic. You | ||
lock the mutex, use the guard like a `&mut T`, and the lock is released | ||
automatically when the guard goes out of scope. | ||
|
||
- The release is handled by `Drop`. There is no need to call a separate unlock | ||
function — this is RAII in action. | ||
|
||
## Poisoning | ||
|
||
- If a thread panics while holding the lock, the value may be in a corrupt | ||
state. | ||
|
||
- To signal this, the standard library uses poisoning. When `Drop` runs during a | ||
panic, the mutex marks itself as poisoned. | ||
|
||
- On the next `lock()`, this shows up as an error. The caller must decide | ||
whether to proceed or handle the error differently. | ||
|
||
- See this example showing the standard library API with poisoning: | ||
<https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=6fb0c2e9e5cbcbbae1c664f4650b8c92> | ||
GlenDC marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
### Mutex Lock Lifecycle | ||
|
||
```bob | ||
+---------------+ +----------------------+ | ||
| Mutex<T> | lock | MutexGuard<T> | | ||
| Unlocked | ------> | Exclusive Access | | ||
+---------------+ +----------------------+ | ||
|
||
^ | drop | ||
| no | | ||
+---------------+ | | ||
| | | ||
| V | ||
|
||
+---------------+ yes +-------------------+ | ||
| Mutex<T> | <---- | Thread panicking? | | ||
| Poisoned | +-------------------+ | ||
+---------------+ | ||
|
||
| | ||
| lock | ||
| | ||
v | ||
|
||
+------------------+ | ||
| Err ( Poisoned ) | | ||
+------------------+ | ||
``` | ||
GlenDC marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
</details> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.