Remove hard-coded encodings from X25519 keys.#1441
Closed
juergw wants to merge 6 commits intogoogle:masterfrom
Closed
Remove hard-coded encodings from X25519 keys.#1441juergw wants to merge 6 commits intogoogle:masterfrom
juergw wants to merge 6 commits intogoogle:masterfrom
Conversation
Instead, let BoringSSL do the parsing and the serialization.
Collaborator
Author
|
This doesn't work, because for some backwards compatibility, we need to ignore extra bytes at the end. So I'll close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, let BoringSSL do the parsing and the serialization.
Also, we replace a custom parsing function for X25519 with two generic functions calls in NativeCrypto.
This allows us to remove this custom function.