Skip to content

Add heapBuffer allocation to BufferAllocator #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguelaranda0 merged 2 commits into from
Jan 8, 2026
Merged

Add heapBuffer allocation to BufferAllocator #1457

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dbd899
Add heapBuffer allocation to BufferAllocator
miguelaranda0 Jan 7, 2026
28bcd4f
Correct whitespace
miguelaranda0 Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/src/main/java/org/conscrypt/BufferAllocator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ public abstract class BufferAllocator {
public AllocatedBuffer allocateDirectBuffer(int capacity) {
return AllocatedBuffer.wrap(ByteBuffer.allocateDirect(capacity));
}

@Override
public AllocatedBuffer allocateHeapBuffer(int capacity) {
return AllocatedBuffer.wrap(ByteBuffer.allocate(capacity));
}
};

/**
Expand All @@ -41,4 +46,9 @@ public static BufferAllocator unpooled() {
* Allocates a direct (i.e. non-heap) buffer with the given capacity.
*/
public abstract AllocatedBuffer allocateDirectBuffer(int capacity);

/**
* Allocates a heap buffer with the given capacity.
*/
public abstract AllocatedBuffer allocateHeapBuffer(int capacity);
}
Loading