Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1566 +/- ##
============================================
- Coverage 46.61% 46.52% -0.10%
- Complexity 678 681 +3
============================================
Files 90 91 +1
Lines 5886 5915 +29
Branches 834 836 +2
============================================
+ Hits 2744 2752 +8
- Misses 2827 2848 +21
Partials 315 315 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new flag --quietMode (default false) to reduce noisy production logs without changing default behavior.
When --quietMode=true, logging for noisy packages is set to WARN at runtime and HAPI request-summary logging is disabled, so URL/per-request INFO chatter is suppressed while WARN/ERROR remains visible.
It is applied in both launcher and worker paths (FhirEtl, ParquetMerger, FetchSearchPageFn setup, and controller pipeline paths), so it works for distributed Beam execution too.
I also propagated quiet mode to incremental merger options from the controller.
About String.format changes: correctness does not depend on this, but it is useful in hot INFO paths.
String.format(...) builds the string even when INFO is disabled; SLF4J placeholder style ("{}") defers formatting unless that log level is enabled.
So in quiet mode it avoids unnecessary formatting overhead.
If you want minimal diff, we can keep this only for high-frequency INFO logs and revert the rest.
I validated with targeted tests: FetchUtilTest, FetchResourcesTest, and FhirSearchUtilTest passed.
closes #1336
will extend this other modules also.. if the way of suppressing is approved
thanks