renderdiff: enable update goldens on commit merge#8771
Merged
Conversation
poweifeng
force-pushed
the
pf/renderdiff-brach-comp-update
branch
2 times, most recently
from
49a6a3c to
fbcfbc1
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
poweifeng
force-pushed
the
pf/renderdiff-brach-comp-update
branch
from
fbcfbc1 to
ff0f8eb
Compare
poweifeng
force-pushed
the
pf/renderdiff-brach-comp-update
branch
21 times, most recently
from
fa7fdae to
237ef4d
Compare
poweifeng
force-pushed
the
pf/renderdiff-brach-comp-update
branch
from
237ef4d to
34878e8
Compare
poweifeng
force-pushed
the
pf/renderdiff-brach-comp-update
branch
9 times, most recently
from
0af75aa to
622c126
Compare
poweifeng
force-pushed
the
pf/renderdiff-brach-comp-update
branch
8 times, most recently
from
b1199dc to
636a922
Compare
Comment on lines
+13
to
+38
| name: update-renderdiff-goldens | ||
| runs-on: 'ubuntu-24.04-4core' | ||
| steps: | ||
| - uses: actions/checkout@v4.1.6 | ||
| with: | ||
| fetch-depth: 0 | ||
| - uses: ./.github/actions/linux-prereq | ||
| - id: get_commit_msg | ||
| uses: ./.github/actions/get-commit-msg | ||
| - name: Prerequisites | ||
| run: pip install tifffile numpy | ||
| - name: Run update script | ||
| env: | ||
| GH_TOKEN: ${{ secrets.FILAMENTBOT_TOKEN }} | ||
| run: | | ||
| GOLDEN_BRANCH=$(echo "${{ steps.get_commit_msg.outputs.msg }}" | python3 test/renderdiff/src/commit_msg.py) | ||
| COMMIT_HASH=$(echo "${{ steps.get_commit_msg.outputs.msg }}" | head -n 1 | tr -d 'commit ') | ||
| if [[ "${GOLDEN_BRANCH}" != "main" ]]; then | ||
| git config --global user.email "filament.bot@gmail.com" | ||
| git config --global user.name "Filament Bot" | ||
| git config --global credential.helper cache | ||
| echo "branch==${GOLDEN_BRANCH}" | ||
| echo "hash==${COMMIT_HASH}" | ||
| python3 test/renderdiff/src/update_golden.py --branch=${GOLDEN_BRANCH} \ | ||
| --merge-to-main --filament-tag=${COMMIT_HASH} --golden-repo-token=${GH_TOKEN} | ||
| fi |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
poweifeng
changed the title
poweifeng
force-pushed
the
pf/renderdiff-brach-comp-update
branch
from
636a922 to
75888ec
Compare
z3moon
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.