Add support for custom morphing #9550
Conversation
| bool hasPositions() const noexcept; | ||
| bool hasTangents() const noexcept; |
There was a problem hiding this comment.
these two could be inline too.
filament/src/details/View.cpp
Outdated
| engine.getZeroTexture(), {}); | ||
|
|
||
| if (UTILS_UNLIKELY(skinning.handle || morphing.handle)) { | ||
| if (UTILS_UNLIKELY(skinning.handle)) { |
There was a problem hiding this comment.
this change makes me nervous. before if you had only morphing enabled, the skinning descriptors were set, but not anymore. I think this part doesn't need to change at all?
There was a problem hiding this comment.
Hmm, you're right. To make the behavior consistent, I reverted this part of changes.
I think this sounds reasonable. Let me create a PR to separate the struct first and will address these comments later on. |
show50726
force-pushed
the
dev/custom-morphing
branch
from
ac85cd4 to
f2c2cda
Compare
| FILAMENT_CHECK_PRECONDITION(mPbHandle) | ||
| << "setPositionsAt() called on a MorphTargetBuffer without a position buffer. Use " | ||
| "withPositions(true) in the Builder."; | ||
| if (!mPbHandle) { |
There was a problem hiding this comment.
I don't think you'd need this if you already have the precondition.
| FILAMENT_CHECK_PRECONDITION(mPbHandle) | ||
| << "setPositionsAt() called on a MorphTargetBuffer without a position buffer. Use " | ||
| "withPositions(true) in the Builder."; | ||
| if (!mPbHandle) { |
| FILAMENT_CHECK_PRECONDITION(mTbHandle) | ||
| << "setTangentsAt() called on a MorphTargetBuffer without a tangent buffer. Use " | ||
| "withTangents(true) in the Builder."; | ||
| if (!mTbHandle) { |
| bool skinning, bool morphing, bool contactShadows, bool hasInstanceBuffer, | ||
| bool skinning, uint8_t morphing, bool contactShadows, bool hasInstanceBuffer, | ||
| uint8_t channels) noexcept { | ||
| uint32_t morphingFlags = uint32_t(morphing) << 9; |
3 participants
BUGS=[443321184]