Skip to content

remove sunDisk in skybox at FL0 #9675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PatRibas wants to merge 5 commits into
base: main
Choose a base branch
from
Open

remove sunDisk in skybox at FL0 #9675

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8daf70e
Remove lighting and simplify skybox in FL0
PatRibas Feb 2, 2026
59182a1
Remove lighting and simplify skybox in FL0
PatRibas Feb 2, 2026
8a6951f
Merge branch 'fl0-lights-skybox' of github.com:PatRibas/filament into…
PatRibas Feb 6, 2026
d673f40
Merge branch 'fl0-lights-skybox' of github.com:PatRibas/filament into…
PatRibas Feb 6, 2026
0cbe333
Merge branch 'fl0-lights-skybox' of github.com:PatRibas/filament into…
PatRibas Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion filament/src/materials/skybox.mat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,10 @@ fragment {
sky = vec4(textureCube(materialParams_skybox, variable_eyeDirection.xyz).rgb, 1.0);
#else
sky = vec4(textureLod(materialParams_skybox, variable_eyeDirection.xyz, 0.0).rgb, 1.0);
#endif
sky.rgb *= frameUniforms.iblLuminance;
#endif // MATERIAL_FEATURE_LEVEL == 0
}
#if MATERIAL_FEATURE_LEVEL > 0
if (materialParams.showSun != 0 && frameUniforms.sun.w >= 0.0) {
vec3 direction = normalize(variable_eyeDirection.xyz);
// Assume the sun is a sphere
Expand All @@ -53,6 +54,7 @@ fragment {
float gradient = pow(1.0 - saturate(x), frameUniforms.sun.w);
sky.rgb = sky.rgb + gradient * sun;
}
#endif // MATERIAL_FEATURE_LEVEL > 0
material.baseColor = sky;
}
}
Expand Down
8 changes: 4 additions & 4 deletions libs/filamat/src/shaders/UibGenerator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,16 +148,16 @@ BufferInterfaceBlock const& UibGenerator::getPerViewUib() noexcept {
{ "dynReserved2", 0, Type::INT },

{ "iblLuminance", 0, Type::FLOAT, Precision::DEFAULT, FeatureLevel::FEATURE_LEVEL_0 },
{ "iblRoughnessOneLevel", 0, Type::FLOAT, Precision::DEFAULT, FeatureLevel::FEATURE_LEVEL_0 },
{ "iblRoughnessOneLevel", 0, Type::FLOAT },
{ "iblSH", 9, Type::FLOAT3 },

// ------------------------------------------------------------------------------------
// Directional Lighting [variant: DIR]
// ------------------------------------------------------------------------------------
{ "lightDirection", 0, Type::FLOAT3, Precision::HIGH, FeatureLevel::FEATURE_LEVEL_0 },
{ "lightDirection", 0, Type::FLOAT3, Precision::HIGH },
{ "padding0", 0, Type::FLOAT },
{ "lightColorIntensity", 0, Type::FLOAT4, Precision::DEFAULT, FeatureLevel::FEATURE_LEVEL_0 },
{ "sun", 0, Type::FLOAT4, Precision::DEFAULT, FeatureLevel::FEATURE_LEVEL_0 },
{ "lightColorIntensity", 0, Type::FLOAT4, Precision::DEFAULT },
{ "sun", 0, Type::FLOAT4, Precision::DEFAULT },
{ "shadowFarAttenuationParams", 0, Type::FLOAT2, Precision::HIGH },

// ------------------------------------------------------------------------------------
Expand Down
4 changes: 4 additions & 0 deletions shaders/src/surface_light_indirect.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#if MATERIAL_FEATURE_LEVEL > 0

//------------------------------------------------------------------------------
// Image based lighting configuration
//------------------------------------------------------------------------------
Expand Down Expand Up @@ -819,3 +821,5 @@ void evaluateIBL(const MaterialInputs material, const PixelParams pixel, inout v
color.rgb += Ft;
#endif
}

#endif // MATERIAL_FEATURE_LEVEL > 0
4 changes: 4 additions & 0 deletions shaders/src/surface_light_punctual.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#if MATERIAL_FEATURE_LEVEL > 0

//------------------------------------------------------------------------------
// Punctual lights evaluation
//------------------------------------------------------------------------------
Expand Down Expand Up @@ -271,3 +273,5 @@ void evaluatePunctualLights(const MaterialInputs material,
}
}
}

#endif // MATERIAL_FEATURE_LEVEL > 0