Open
Conversation
Contributor
poweifeng
commented
Feb 12, 2026
poweifeng
commented
- add half float as source type
- gray-scaled output when src-channel=1 and dest-channel=3 or 4
poweifeng
force-pushed
the
pf/datashaper
branch
from
9a90c8e to
e2a2fe7
Compare
romainguy
reviewed
Feb 13, 2026
filament/backend/src/DataReshaper.h
Outdated
| } | ||
| for (size_t channel = srcChannelCount; channel < dstChannelCount; ++channel) { | ||
| out[channel] = dstMaxValue; | ||
| if (srcChannelCount == 1 && (dstChannelCount == 3 || dstChannelCount == 4)) { |
Contributor
There was a problem hiding this comment.
BTW have we checked if the compiler outlines the branches? If not it might be worth providing multiple loops for the various configurations to avoid so many branches so deep inside the nested loops.
Contributor
Author
There was a problem hiding this comment.
that's a good point. I made all the branches constexpr instead, but had to add a templating layer.
Contributor
Author
There was a problem hiding this comment.
but I guess the downside is increase in binary size... but anyways, let me know what you think.
Contributor
There was a problem hiding this comment.
Looks great, thanks for doing that! I was mostly concerned about performance for large textures.
poweifeng
force-pushed
the
pf/datashaper
branch
from
e2a2fe7 to
c0b8d71
Compare
- add half float as source type - gray-scaled output when src-channel=1 and dest-channel=3 or 4 - Ensure that per-pixel work is as-constexpr-as-possible
poweifeng
force-pushed
the
pf/datashaper
branch
from
c0b8d71 to
8885669
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.