VK: More refactor of the external sampler flow#9717
Open
rafadevai wants to merge 1 commit intogoogle:mainfrom
Open
VK: More refactor of the external sampler flow#9717rafadevai wants to merge 1 commit intogoogle:mainfrom
rafadevai wants to merge 1 commit intogoogle:mainfrom
Conversation
Query the texture directly to know if it uses an external sampler or not. This is already known when the texture is created. Remove dead code related to the external sampler flow. Simplify the code of the VulkanExternalImageManager class. Only create a new vkSet per updateSetAndLayout instead of one per external sampler.
rafadevai
force-pushed
the
external_sampler_flow_optimization
branch
from
37a50d0 to
4c92c22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query the texture directly to know if it uses an external sampler or not. This is already known when the texture is created.
Remove dead code related to the external sampler flow.
Simplify the code of the VulkanExternalImageManager class.