Silently disable MSAA for FL0.#9807
Merged
pixelflinger merged 7 commits intogoogle:mainfrom Mar 18, 2026
Merged
Conversation
pixelflinger
requested changes
Mar 17, 2026
Collaborator
pixelflinger
left a comment
pixelflinger
left a comment
There was a problem hiding this comment.
I can't see where mFeatureLevel is initialized with the real value.
Contributor
Author
Whoops... Done. |
pixelflinger
approved these changes
Mar 17, 2026
z3moon
approved these changes
Mar 18, 2026
Contributor
|
LGTM. it'd be nice to add a comment clarifying why MSAA is disabled for FL0 to be helpful for future reference. |
… view-antialiasing
… view-antialiasing
Contributor
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids a bug where the frame graph would insert a post-process pass and skip sRGB emulation.