android: [render-validation] add more test result details#9812
Merged
android: [render-validation] add more test result details#9812
Conversation
bejado
approved these changes
Mar 18, 2026
Comment on lines
+44
to
+52
| if (!deviceName.empty()) fullInfo += deviceName.c_str(); | ||
| if (!driverName.empty()) { | ||
| if (!fullInfo.empty()) fullInfo += " | "; | ||
| fullInfo += driverName.c_str(); | ||
| } | ||
| if (!driverInfo.empty()) { | ||
| if (!fullInfo.empty()) fullInfo += " | "; | ||
| fullInfo += driverInfo.c_str(); | ||
| } |
Member
There was a problem hiding this comment.
This bit is repeated down below. Maybe refactor to a helper function?
Contributor
Author
There was a problem hiding this comment.
good point! I simplified this.
Add the following information: - Android build fingerprint, version - GPU driver name, info, vendor name - Time elapsed for test - Rendered images (as oppose to diff image) filament-utils: - Add DeviceUtils to hook into Platform methods for reading out strings about gpu vendor, driver. Fix "tolerance" in test definition
poweifeng
force-pushed
the
pf/android-render-val-add-info
branch
from
a7b1260 to
d184ba5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the following information:
filament-utils:
Fix "tolerance" in test definition