Skip to content

More robust C++20 <span> check #8631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

More robust C++20 <span> check #8631

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7158c26
More robust <span> check
cyyever Jun 29, 2025
0d44673
Merge branch 'master' into more_span_check
cyyever Jul 11, 2025
5751f1a
Merge branch 'master' into more_span_check
cyyever Sep 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions include/flatbuffers/stl_emulation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@
// See: https://en.cppreference.com/w/cpp/utility/feature_test
#if defined(__cplusplus) && __cplusplus >= 202002L \
|| (defined(_MSVC_LANG) && _MSVC_LANG >= 202002L)
#define FLATBUFFERS_USE_STD_SPAN 1
#if __has_include(<span>)
#define FLATBUFFERS_USE_STD_SPAN 1
#endif
#endif
#endif // FLATBUFFERS_USE_STD_SPAN

Expand Down Expand Up @@ -321,7 +323,7 @@ namespace internal {
SpanIterator(pointer ptr) : ptr_(ptr) {}
reference operator*() const { return *ptr_; }
pointer operator->() { return ptr_; }
SpanIterator& operator++() { ptr_++; return *this; }
SpanIterator& operator++() { ptr_++; return *this; }
SpanIterator operator++(int) { auto tmp = *this; ++(*this); return tmp; }

friend bool operator== (const SpanIterator& lhs, const SpanIterator& rhs) { return lhs.ptr_ == rhs.ptr_; }
Expand Down