Skip to content

Conversation

@chapman20j
Copy link
Collaborator

What does this PR do?

  • Updates nnx.set_mode to nnx.view to emphasize weight sharing. Modules still implement set_mode.
  • Updates nnx.set_mode_info to nnx.view_info.
  • Updates train_mode and eval_mode to train_view and eval_view.
  • Adds a guide on how to use nnx.view

Checklist

  • This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other checks if that's the case).
  • This change is discussed in a Github issue/discussion (please add a link).
  • The documentation and docstrings adhere to the documentation guidelines.
  • This change includes necessary high-coverage tests. (No quality testing = no merge!)

@gemini-code-assist
Copy link

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant