Update the RNG guide with split and without StateAxes#5363
Open
samanklesaria wants to merge 1 commit intogoogle:mainfrom
Open
Update the RNG guide with split and without StateAxes#5363samanklesaria wants to merge 1 commit intogoogle:mainfrom
samanklesaria wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
samanklesaria
commented
Mar 20, 2026
| def split(self, k: tp.Mapping[filterlib.Filter, int | tuple[int, ...]] | int | tuple[int, ...]): | ||
| """ | ||
| Splits the keys of the newly created ``Rngs`` object. | ||
| Splits the keys of a ``Rngs`` object. |
Collaborator
Author
There was a problem hiding this comment.
Should probably be a separate PR, but it's such a minor fix
samanklesaria
force-pushed
the
rng_guide_update
branch
from
3087155 to
be3ff27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the
forkmethods for RNGs have been split off from thesplitmethods, we need to update the RNG guide to use thesplitmethods (or users will see deprecation warnings when they try to follow the guide). Also:StateAxesis not tree-mode compatible, so we have to remove their use in the guide.