Skip to content

Fix issue #336 #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix issue #336 #339

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c60f9c9
Fix issue #336
ly85206559 Aug 2, 2017
a4584a7
Put code into if conditional statement.
ly85206559 Aug 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion flexbox/src/main/java/com/google/android/flexbox/FlexboxLayoutManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,8 +368,10 @@ public List<FlexLine> getFlexLines() {

@Override
public int getDecorationLengthMainAxis(View view, int index, int indexInFlexLine) {
View v = mRecycler.getViewForPosition(index);
calculateItemDecorationsForChild(v, TEMP_RECT);
if (isMainAxisDirectionHorizontal()) {
return getLeftDecorationWidth(view) + getRightDecorationWidth(view);
return getLeftDecorationWidth(v) + getRightDecorationWidth(v);
Copy link

@ghost ghost Aug 7, 2017 •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't like this solution. Why? You're creating new View instance instead of reusing the existing one.

Code from lines 371 and 372 you should put into if conditional statement, but instead of using new v variable, please use existing view.

To be more precise:

if (isMainAxisDirectionHorizontal()) {
         view = mRecycler.getViewForPosition(index);
         calculateItemDecorationsForChild(view, TEMP_RECT);
         return getLeftDecorationWidth(view) + getRightDecorationWidth(view);
} else {
          return getTopDecorationHeight(view) + getBottomDecorationHeight(view);
}

Another thing - did you write any test or check it on more than 3 different devices?

Copy link
Author

@ly85206559 ly85206559 Aug 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.I have modify the code.
But i have to say.
view = mRecycler.getViewForPosition(index);
calculateItemDecorationsForChild(view, TEMP_RECT);
Here actually is not the best solution because calculateItemDecorationsForChild is invoked frequent.But it is a solution.
At last. I write the test code and test on HUAWEI and SAMSUNG devices.

} else {
return getTopDecorationHeight(view) + getBottomDecorationHeight(view);
}
Expand Down