Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
nigeltao
reviewed
Mar 16, 2022
CMakeLists.txt
Outdated
| @@ -0,0 +1,31 @@ | |||
| cmake_minimum_required(VERSION 3.13) | |||
|
|
|||
| set(FUSE_ARCHIVE_VERSION 0.0.1) | |||
Collaborator
There was a problem hiding this comment.
Does the "0.0.1" need updating? Latest is https://github.com/google/fuse-archive/releases/tag/v0.1.9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A thousand apologies for complicating what I feel is an elegant project -- I do really appreciate the simplicity of it all, including the good-old-fashioned
Makefile.For my purposes, I gotta create a
.deb, and this is the easiest way I know of: usecmakefor the build system.If you reject this PR I'm not offended at all.