Stop the child output reading when the child process ends. #1712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
cl/762172820
branch
from
f5ffd83 to
ea27154
Compare
Otherwise, the child process could terminate without fully closing the pipes, causing unwanted delays - see the added test. PiperOrigin-RevId: 762172820
copybara-service
bot
force-pushed
the
cl/762172820
branch
from
ea27154 to
23be287
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop the child output reading when the child process ends.
Otherwise, the child process could terminate without fully closing the pipes, causing unwanted delays - see the added test.