Skip to content

Enforce batch timeout even when not running inputs. #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enforce batch timeout even when not running inputs. #1758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions centipede/runner.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,13 +196,15 @@ static void CheckWatchdogLimits() {
};
const uint64_t input_start_time = state.input_start_time;
const uint64_t batch_start_time = state.batch_start_time;
if (input_start_time == 0 || batch_start_time == 0) return;
if (batch_start_time == 0) return;
const Resource resources[] = {
{Resource{
/*what=*/"Per-input timeout",
/*units=*/"sec",
/*value=*/curr_time - input_start_time,
/*limit=*/state.run_time_flags.timeout_per_input,
/*limit=*/input_start_time == 0
? 0
: state.run_time_flags.timeout_per_input.load(),
/*ignore_report=*/state.run_time_flags.ignore_timeout_reports != 0,
/*failure=*/kExecutionFailurePerInputTimeout.data(),
}},
Expand All @@ -218,7 +220,9 @@ static void CheckWatchdogLimits() {
/*what=*/"RSS limit",
/*units=*/"MB",
/*value=*/GetPeakRSSMb(),
/*limit=*/state.run_time_flags.rss_limit_mb,
/*limit=*/input_start_time == 0
? 0
: state.run_time_flags.rss_limit_mb.load(),
/*ignore_report=*/false,
/*failure=*/kExecutionFailureRssLimitExceeded.data(),
}},
Expand Down Expand Up @@ -269,8 +273,8 @@ static void CheckWatchdogLimits() {
while (true) {
sleep(1);

// No calls to ResetInputTimer() yet: input execution hasn't started.
if (state.input_start_time == 0) continue;
// No calls to ResetInputTimer() yet: batch execution hasn't started.
if (state.batch_start_time == 0) continue;

CheckWatchdogLimits();
}
Expand Down