Use the stop time to set batch execution deadlines. #1836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
cl/791875139
branch
from
75f492d to
e4ce81e
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
cl/791875139
branch
from
e4ce81e to
4e53ed8
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
cl/791875139
branch
6 times, most recently
from
13e75af to
532a10f
Compare
copybara-service
bot
force-pushed
the
cl/791875139
branch
2 times, most recently
from
c67b2db to
b7fadb3
Compare
Do not report crashes on stop conditions. This allows the stop time to be enforced more precisely, and avoids reporting the potential crashes due to early stopping. After this we don't need to set batch timeout to the test time limit - it was a quick workaround for the same purpose. Change the e2e unit test time to 10s to reduce flakiness. PiperOrigin-RevId: 791875139
copybara-service
bot
force-pushed
the
cl/791875139
branch
from
b7fadb3 to
218b4f2
Compare
copybara-service
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the stop time to set batch execution deadlines.
Do not report crashes on stop conditions.
This allows the stop time to be enforced more precisely, and avoids reporting the potential crashes due to early stopping.
After this we don't need to set batch timeout to the test time limit - it was a quick workaround for the same purpose.
Change the e2e unit test time to 10s to reduce flakiness.