Skip to content

Fix InRegexp to support alternation '|' (#1830) #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix InRegexp to support alternation '|' (#1830) #1878

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
359c802
Fix InRegexp to support alternation '|' (#1830)
snk-git-hub Oct 7, 2025
47d36ad
Remove MODULE.bazel.lock and dist directory from PR
snk-git-hub Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions fuzztest/internal/domains/regexp_dfa.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,14 +253,25 @@ std::optional<int> RegexpDFA::NextState(
std::unique_ptr<re2::Prog> RegexpDFA::CompileRegexp(absl::string_view regexp) {
// Build the RegexpDFA for only full match.
std::string full_text_regexp(regexp);
if (regexp.empty() || regexp[0] != '^')

// Check if we need to add anchors
bool needs_start_anchor = regexp.empty() || regexp[0] != '^';
bool needs_end_anchor = regexp.empty() || regexp.back() != '$';

if (needs_start_anchor || needs_end_anchor) {
full_text_regexp = "(?:" + full_text_regexp + ")";
}

if (needs_start_anchor) {
full_text_regexp = "^" + full_text_regexp;
if (full_text_regexp.back() != '$') full_text_regexp += "$";
}
if (needs_end_anchor) {
full_text_regexp += "$";
}

re2::Regexp* re =
re2::Regexp::Parse(full_text_regexp, re2::Regexp::LikePerl, nullptr);

// Is the regexp valid?
FUZZTEST_PRECONDITION(re != nullptr) << "Invalid RE2 regular expression.";
re2::Prog* prog = re->CompileToProg(0);
FUZZTEST_CHECK(prog != nullptr) << "RE2 compilation failed!";
Expand Down