Merged
Conversation
This patch makes a couple changes to the container image definition so that it works with recent changes. * It updates the container image to ubuntu:24.04 which has the default python version of 3.12 so that it matches that quasi-hermetic toolchain setup in bazel. Otherwise we get errors when trying to load pybind modules as they are compiled against 3.12. * We remove the python package installation requirements due to them now being handled by bazel and the file being used no longer existing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch makes a couple changes to the container image definition so that it works with recent changes.