Bump timeout for requirements test#356
Merged
boomanaiden154 merged 2 commits intogoogle:mainfrom Jul 4, 2025
Merged
Conversation
This test takes a while and times out on quite a few systems (including CI and my sandy bridge desktop). Bump the timeout by adding a timeout option to the rule which passes extra keyword arguments to the underlying test rule.
virajbshah
approved these changes
Jul 4, 2025
|
|
||
| compile_pip_requirements_3_12( | ||
| name = "requirements_3_12", | ||
| timeout = "moderate", |
Contributor
There was a problem hiding this comment.
Nice find! I was under the impression what we'd have to patch @rules_python to adjust the timeout, convenient that the kwargs get forwarded to the generated test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test takes a while and times out on quite a few systems (including CI and my sandy bridge desktop). Bump the timeout by adding a timeout option to the rule which passes extra keyword arguments to the underlying test rule.