Use if chains instead of match case to avoid TF warnings#357
Merged
boomanaiden154 merged 1 commit intogoogle:mainfrom Jul 7, 2025
Merged
Conversation
TF will issue warnings around match case statements. We can annotate this with a function decorator to prevent autograph conversion, but the performance implications of this, especially for JIT compilation, are unclear. Use constructs that are supported even if they are slightly less clean/maintainable to get rid of the warning and avoid any performance penalties.
ondrasej
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TF will issue warnings around match case statements. We can annotate this with a function decorator to prevent autograph conversion, but the performance implications of this, especially for JIT compilation, are unclear. Use constructs that are supported even if they are slightly less clean/maintainable to get rid of the warning and avoid any performance penalties.