runtimevar: switch to utilising opentelemetry#3581
Merged
vangent merged 21 commits intogoogle:masterfrom Jul 5, 2025
Merged
Conversation
…/go-cloud into otel-migration-runtimevar
…/go-cloud into otel-migration-runtimevar
…/go-cloud into otel-migration-runtimevar
Contributor
Author
|
@vangent proceed to review appropriately |
vangent
reviewed
Jul 3, 2025
vangent
requested changes
Jul 3, 2025
Contributor
vangent
left a comment
vangent
left a comment
There was a problem hiding this comment.
also please run ./internal/testing/gomodcleanup.sh, looks like it wants to change go.mod for etcd.
Contributor
Author
|
@vangent I improved the diff check to allow it to be reused and cleanedup the lint issues. I also would like to bring to your attention a small change related to comparing errors using equality sign. I changed that comparison to use errors.Is() |
vangent
reviewed
Jul 4, 2025
vangent
approved these changes
Jul 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to slowly migrate go-cloud into utilising open telemetry see:
#3539
#2877
PR affects :
runtimevar