Open
Conversation
reject cross-domain bearer realm urls before sending credentials, and add regression tests.
Author
|
hi @Subserial — this adds realm URL validation to prevent credentials from being sent to an attacker-controlled token service. minimal change, regression test included. happy to address any feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #2193
this change parses and validates the bearer realm value (scheme + host), and rejects cross-domain realm hosts before any credential-bearing token request is made. the check is bound to the registry effective domain (e.g. "registry-1.docker.io" and "auth.docker.io" are allowed).
tests included:
open questions: