fixup! feat: Improve support for custom property defaults

Author: stevehipwell

github/orgs_properties_test.go

@@ -11,6 +11,7 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
+	"github.com/google/go-cmp/cmp/cmpopts"
 )
 
 func TestOrganizationsService_GetAllCustomProperties(t *testing.T) {
@@ -484,3 +485,255 @@ func TestOrganizationsService_CreateOrUpdateRepoCustomPropertyValues(t *testing.
 		return client.Organizations.CreateOrUpdateRepoCustomPropertyValues(ctx, "o", nil, nil)
 	})
 }
+
+func TestCustomPropertyDefaultValueString(t *testing.T) {
+	t.Parallel()
+	for _, d := range []struct {
+		testName string
+		property *CustomProperty
+		ok       bool
+		want     string
+	}{
+		{
+			testName: "invalid_type",
+			property: &CustomProperty{
+				ValueType:    PropertyValueTypeMultiSelect,
+				DefaultValue: []string{"a", "b"},
+			},
+			ok:   false,
+			want: "",
+		},
+		{
+			testName: "string_invalid_value",
+			property: &CustomProperty{
+				ValueType:    PropertyValueTypeString,
+				DefaultValue: []string{"a", "b"},
+			},
+			ok:   false,
+			want: "",
+		},
+		{
+			testName: "string_nil_value",
+			property: &CustomProperty{
+				ValueType:    PropertyValueTypeString,
+				DefaultValue: nil,
+			},
+			ok:   false,
+			want: "",
+		},
+		{
+			testName: "string_value",
+			property: &CustomProperty{
+				ValueType:    PropertyValueTypeString,
+				DefaultValue: "test-string",
+			},
+			ok:   true,
+			want: "test-string",
+		},
+		{
+			testName: "single_select_invalid_value",
+			property: &CustomProperty{
+				ValueType:    PropertyValueTypeSingleSelect,
+				DefaultValue: []string{"a", "b"},
+			},
+			ok:   false,
+			want: "",
+		},
+		{
+			testName: "single_select_nil_value",
+			property: &CustomProperty{
+				ValueType:    PropertyValueTypeSingleSelect,
+				DefaultValue: nil,
+			},
+			ok:   false,
+			want: "",
+		},
+		{
+			testName: "single_select_value",
+			property: &CustomProperty{
+				ValueType:    PropertyValueTypeSingleSelect,
+				DefaultValue: "test-string",
+			},
+			ok:   true,
+			want: "test-string",
+		},
+		{
+			testName: "url_invalid_value",
+			property: &CustomProperty{
+				ValueType:    PropertyValueTypeURL,
+				DefaultValue: []string{"a", "b"},
+			},
+			ok:   false,
+			want: "",
+		},
+		{
+			testName: "url_nil_value",
+			property: &CustomProperty{
+				ValueType:    PropertyValueTypeURL,
+				DefaultValue: nil,
+			},
+			ok:   false,
+			want: "",
+		},
+		{
+			testName: "url_value",
+			property: &CustomProperty{
+				ValueType:    PropertyValueTypeURL,
+				DefaultValue: "http://example.com",
+			},
+			ok:   true,
+			want: "http://example.com",
+		},
+	} {
+		t.Run(d.testName, func(t *testing.T) {
+			t.Parallel()
+			got, ok := d.property.DefaultValueString()
+
+			if ok != d.ok {
+				t.Fatalf("CustomProperty.DefaultValueString set ok to %+v, want %+v", ok, d.ok)
+			}
+
+			if got != d.want {
+				t.Fatalf("CustomProperty.DefaultValueString returned %+v, want %+v", got, d.want)
+			}
+		})
+	}
+}
+
+func TestCustomPropertyDefaultValueStrings(t *testing.T) {
+	t.Parallel()
+	for _, d := range []struct {
+		testName string
+		property *CustomProperty
+		ok       bool
+		want     []string
+	}{
+		{
+			testName: "invalid_type",
+			property: &CustomProperty{
+				ValueType:    PropertyValueTypeString,
+				DefaultValue: "test",
+			},
+			ok:   false,
+			want: []string{},
+		},
+		{
+			testName: "multi_select_invalid_value",
+			property: &CustomProperty{
+				ValueType:    PropertyValueTypeMultiSelect,
+				DefaultValue: "test",
+			},
+			ok:   false,
+			want: []string{},
+		},
+		{
+			testName: "multi_select_nil_value",
+			property: &CustomProperty{
+				ValueType:    PropertyValueTypeMultiSelect,
+				DefaultValue: nil,
+			},
+			ok:   false,
+			want: []string{},
+		},
+		{
+			testName: "multi_select_single_value",
+			property: &CustomProperty{
+				ValueType:    PropertyValueTypeMultiSelect,
+				DefaultValue: []string{"a"},
+			},
+			ok:   true,
+			want: []string{"a"},
+		},
+		{
+			testName: "multi_select_multi_value",
+			property: &CustomProperty{
+				ValueType:    PropertyValueTypeMultiSelect,
+				DefaultValue: []string{"a", "b"},
+			},
+			ok:   true,
+			want: []string{"a", "b"},
+		},
+	} {
+		t.Run(d.testName, func(t *testing.T) {
+			t.Parallel()
+			got, ok := d.property.DefaultValueStrings()
+
+			if ok != d.ok {
+				t.Fatalf("CustomProperty.DefaultValueStrings set ok to %+v, want %+v", ok, d.ok)
+			}
+
+			if !cmp.Equal(got, d.want, cmpopts.EquateEmpty()) {
+				t.Fatalf("CustomProperty.DefaultValueStrings returned %+v, want %+v", got, d.want)
+			}
+		})
+	}
+}
+
+func TestCustomPropertyDefaultValueBool(t *testing.T) {
+	t.Parallel()
+	for _, d := range []struct {
+		testName string
+		property *CustomProperty
+		ok       bool
+		want     bool
+	}{
+		{
+			testName: "invalid_type",
+			property: &CustomProperty{
+				ValueType:    PropertyValueTypeString,
+				DefaultValue: "test",
+			},
+			ok:   false,
+			want: false,
+		},
+		{
+			testName: "true_false_invalid_value",
+			property: &CustomProperty{
+				ValueType:    PropertyValueTypeTrueFalse,
+				DefaultValue: "test",
+			},
+			ok:   false,
+			want: false,
+		},
+		{
+			testName: "true_false_nil_value",
+			property: &CustomProperty{
+				ValueType:    PropertyValueTypeTrueFalse,
+				DefaultValue: nil,
+			},
+			ok:   false,
+			want: false,
+		},
+		{
+			testName: "true_false_true_value",
+			property: &CustomProperty{
+				ValueType:    PropertyValueTypeTrueFalse,
+				DefaultValue: "true",
+			},
+			ok:   true,
+			want: true,
+		},
+		{
+			testName: "true_false_false_value",
+			property: &CustomProperty{
+				ValueType:    PropertyValueTypeTrueFalse,
+				DefaultValue: "false",
+			},
+			ok:   true,
+			want: false,
+		},
+	} {
+		t.Run(d.testName, func(t *testing.T) {
+			t.Parallel()
+			got, ok := d.property.DefaultValueBool()
+
+			if ok != d.ok {
+				t.Fatalf("CustomProperty.DefaultValueBool set ok to %+v, want %+v", ok, d.ok)
+			}
+
+			if ok != d.ok {
+				t.Fatalf("CustomProperty.DefaultValueBool returned %+v, want %+v", got, d.want)
+			}
+		})
+	}
+}