Skip to content

Conversation

@elminster-aom
Copy link
Contributor

@elminster-aom elminster-aom commented Nov 19, 2025

Related with #3813

Summary

From REST API endpoints for Enterprise SCIM docs, implements:

Other changes

  • Fix Enterprise.ListProvisionedSCIMGroups Accept header, set it to application/scim+json
  • Correct Enterprise.ListProvisionedSCIMGroups unti test function name

Copy link
Contributor Author

@elminster-aom elminster-aom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found an incoherence about the Accept header. While the document states for all endpoints:

Headers
accept string
Setting to application/vnd.github+json is recommended.

Their example endpoints use different values. For example on GET .../Users: -H "Accept: application/scim+json"

Reported to GitHub support and they confirmed that:

The correct header is Accept: application/scim+json.

Fix here for EnterpriseService.ListProvisionedSCIMGroups

TODO

Fix for SCIMService endpoints too.

@elminster-aom elminster-aom marked this pull request as ready for review November 19, 2025 08:19
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.42%. Comparing base (ea7dd81) to head (b22b4eb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3839   +/-   ##
=======================================
  Coverage   92.41%   92.42%           
=======================================
  Files         197      197           
  Lines       14152    14167   +15     
=======================================
+ Hits        13079    13094   +15     
  Misses        884      884           
  Partials      189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @elminster-aom!
Just a few tweaks, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29

Comment on lines +134 to +140
Filter string `url:"filter,omitempty"`
// Used for pagination: the starting index of the first result to return when paginating through values.
// Default: 1.
StartIndex int `url:"startIndex,omitempty"`
// Used for pagination: the number of results to return per page.
// Default: 30.
Count int `url:"count,omitempty"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These omitempty fields should be pointers since they are optional values.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the previous PR, #discussion_r2524023305; @alexandear recommended this structure for options structures:

go-github/github/github.go

Lines 262 to 288 in 4ed75ac

type ListCursorOptions struct {
// For paginated result sets, page of results to retrieve.
Page string `url:"page,omitempty"`
// For paginated result sets, the number of results to include per page.
PerPage int `url:"per_page,omitempty"`
// For paginated result sets, the number of results per page (max 100), starting from the first matching result.
// This parameter must not be used in combination with last.
First int `url:"first,omitempty"`
// For paginated result sets, the number of results per page (max 100), starting from the last matching result.
// This parameter must not be used in combination with first.
Last int `url:"last,omitempty"`
// A cursor, as given in the Link header. If specified, the query only searches for events after this cursor.
After string `url:"after,omitempty"`
// A cursor, as given in the Link header. If specified, the query only searches for events before this cursor.
Before string `url:"before,omitempty"`
// A cursor, as given in the Link header. If specified, the query continues the search using this cursor.
Cursor string `url:"cursor,omitempty"`
}
// UploadOptions specifies the parameters to methods that support uploads.
type UploadOptions struct {

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsReview PR is awaiting a review before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants