Add driver digest verification in confidential GPU driver installation flow#567
Merged
meetrajvala merged 2 commits intocs_cgpu_h100from May 2, 2025
Merged
Add driver digest verification in confidential GPU driver installation flow#567meetrajvala merged 2 commits intocs_cgpu_h100from
meetrajvala merged 2 commits intocs_cgpu_h100from
Conversation
meetrajvala
force-pushed
the
mhvcgpu2
branch
3 times, most recently
from
203eb99 to
571c5e8
Compare
Contributor
Author
|
/gcbrun |
yawangwang
approved these changes
Apr 24, 2025
ghost
approved these changes
Apr 25, 2025
alexmwu
approved these changes
May 1, 2025
launcher/image/preload.sh
Outdated
| readonly GPU_REF_VALUES_PATH="${CS_PATH}/gpu" | ||
| readonly COS_GPU_INSTALLER_IMAGE_REF="${GPU_REF_VALUES_PATH}/cos_gpu_installer_image_ref" | ||
| readonly COS_GPU_INSTALLER_IMAGE_DIGEST="${GPU_REF_VALUES_PATH}/cos_gpu_installer_image_digest" | ||
| readonly DRIVER_DIGEST_SHA256SUM="${GPU_REF_VALUES_PATH}/driver_digest_sha256sum" |
Contributor
There was a problem hiding this comment.
Should we store by driver version? For example, ${GPU_REF_VALUES_PATH}/${driver_version}/driver_digest_sha256sum
Contributor
Author
There was a problem hiding this comment.
Currently, we have only default driver version support (for H100 gpu only) so it might just one more directory in path. I can accomodate this when we extend support for multiple cGPU families requiring different driver versions (There is a tracking ticket for this).
meetrajvala
force-pushed
the
mhvcgpu2
branch
2 times, most recently
from
bbc5e6d to
9b1268b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
Testing:
Changes which would be part of follow-up PR: