[keymanager/wsd] GET /v1/keys enumerate keys#653
Open
atulpatildbz wants to merge 5 commits intogoogle:mainfrom
Open
[keymanager/wsd] GET /v1/keys enumerate keys#653atulpatildbz wants to merge 5 commits intogoogle:mainfrom
atulpatildbz wants to merge 5 commits intogoogle:mainfrom
Conversation
atulpatildbz
changed the title
atulpatildbz
force-pushed
the
wsd_enumerate_go
branch
from
f263891 to
84401d9
Compare
atulpatildbz
force-pushed
the
wsd_enumerate_go
branch
6 times, most recently
from
bbccf9e to
6fd86d5
Compare
atulpatildbz
force-pushed
the
wsd_enumerate_go
branch
2 times, most recently
from
ab9e5b2 to
e909897
Compare
Key changes: - Renamed endpoint from /v1/keys:generate_kem to /v1/keys:generate_key. - Restructured `GenerateKeyRequest` to use a nested `Algorithm` definition containing `Type` and an algorithm-specific `Params` object with `kem_id`. - Added support for `KEY_PROTECTION_VM_EMULATED` in the KeyProtectionMechanism enum and established this as the default and only supported mechanism for Vanguard so far. - Validated lifecycle configurations and parsed `Algorithm` appropriately according to updated schemas. - Updated associated unit and integration tests (server_test.go, integration_test.go) to use the new endpoints and the new request signature.
* Refactor GenerateKey algorithm validation to support future key types * remove KeyProtectionMechanism
atulpatildbz
force-pushed
the
wsd_enumerate_go
branch
2 times, most recently
from
02da1b8 to
76a15a5
Compare
atulpatildbz
force-pushed
the
wsd_enumerate_go
branch
2 times, most recently
from
ce5b130 to
dddbb99
Compare
atulpatildbz
force-pushed
the
wsd_enumerate_go
branch
from
3ede68e to
86fa06d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the Enumerate Keys API (
GET /v1/keys) for the Workload Service Daemon (WSD).It allows clients to list active KEM keys stored in the in-memory Key Registry.
GET /v1/keysendpoint.snake_caseJSON tags and stringified enums.Dependencies
This PR is created on top of, and requires:
Testing
Unit Tests
server_test.go- covering success, empty state, and error handling.KeyProtectionMechanism.Manual Testing
GET /v1/keysreturns empty list initially.POST /v1/keys:generate_kemsuccessfully creates a key.GET /v1/keysreturns the created key with correctsnake_casefields and stringified enums/durations.