Open
Conversation
Collaborator
Author
|
/gcbrun |
alexmwu
requested changes
Feb 19, 2026
Collaborator
Author
|
/gcbrun |
1 similar comment
Collaborator
Author
|
/gcbrun |
jkl73
reviewed
Feb 24, 2026
|
|
||
| // The following values are based on NVIDIA's GPU architecture generations. | ||
| const ( | ||
| GPU_ARCHITECTURE_UNSPECIFIED GPUArchitectureType = 0 // Unspecified architecture. |
Contributor
There was a problem hiding this comment.
Can you fix all the linter issues
Sibcgh
force-pushed
the
gpu_attestation_evidence_types
branch
4 times, most recently
from
2a2d521 to
5623e74
Compare
Collaborator
Author
|
/gcbrun |
yawangwang
requested changes
Feb 24, 2026
|
|
||
| // The following values are based on NVIDIA's GPU architecture generations. | ||
| const ( | ||
| GpuArchitectureUnspecified GPUArchitectureType = 0 // Unspecified architecture. |
Collaborator
There was a problem hiding this comment.
GpuArchitectureUnspecified GPUArchitectureType = iota for enum type
| GpuArchitectureAmpere GPUArchitectureType = 6 // Ampere architecture. | ||
| GpuArchitectureAda GPUArchitectureType = 7 // Ada architecture. | ||
| GpuArchitectureHopper GPUArchitectureType = 8 // Hopper architecture. | ||
| GpuArchitectureUnknown GPUArchitectureType = 9 // Unknown architecture. |
Collaborator
There was a problem hiding this comment.
this seems to be duplicate of GpuArchitectureUnspecified, should be renamed to GpuArchitectureUnsupported
Comment on lines
109
to
117
| // NvidiaAttestationReportSpt represents the SPT attestation report for NVIDIA GPUs. | ||
| type NvidiaAttestationReportSpt struct { | ||
| Spt *SinglePassthroughAttestation `json:"spt,omitempty"` | ||
| } | ||
|
|
||
| // NvidiaAttestationReportMpt represents the MPT attestation report for NVIDIA GPUs, containing multiple GPU quotes. | ||
| type NvidiaAttestationReportMpt struct { | ||
| Mpt *MultiGpuSecurePassthroughAttestation `json:"mpt,omitempty"` | ||
| } |
| } | ||
|
|
||
| // SinglePassthroughAttestation is a placeholder for the 'spt' field. | ||
| type SinglePassthroughAttestation struct{} |
Collaborator
There was a problem hiding this comment.
this struct should contain single GPUInfo
Collaborator
Author
|
/gcbrun |
auto-merge was automatically disabled
February 27, 2026 23:07
Pull request was closed
Sibcgh
force-pushed
the
gpu_attestation_evidence_types
branch
from
5623e74 to
3ced14c
Compare
Collaborator
Author
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GPU attestation data structures based upon API design