[KeyManager] Add KeyClaims proto and generation script.#671
Merged
atulpatildbz merged 4 commits intogoogle:mainfrom Feb 28, 2026
Merged
[KeyManager] Add KeyClaims proto and generation script.#671atulpatildbz merged 4 commits intogoogle:mainfrom
atulpatildbz merged 4 commits intogoogle:mainfrom
Conversation
alexmwu
reviewed
Feb 20, 2026
Contributor
alexmwu
left a comment
alexmwu
left a comment
There was a problem hiding this comment.
VM Attestation message and dependencies belong in https://github.com/GoogleCloudPlatform/confidential-space/tree/main/server not here.
atulpatildbz
commented
Feb 24, 2026
atulpatildbz
force-pushed
the
keyclaims_proto
branch
from
eeccb0c to
8782da3
Compare
NilanjanDaw
reviewed
Feb 26, 2026
|
|
||
| // The key is held by the Key Protection Services VM, and is endorsed by a pair of CVM | ||
| // attestations, from the Workload Services Daemon and Key Protection VM. | ||
| KEY_PROTECTION_VM = 2; |
Collaborator
There was a problem hiding this comment.
We also need the KEY_PROTECTION_VM_EMULATED mode here.
|
|
||
| message KeyClaims { | ||
| // The following two messages are used for keys whose protection mechanism is | ||
| // KEY_PROTECTION_VM. |
Collaborator
There was a problem hiding this comment.
or KEY_PROTECTION_VM_EMULATED
atulpatildbz
force-pushed
the
keyclaims_proto
branch
from
9afb21f to
f0554da
Compare
NilanjanDaw
reviewed
Feb 27, 2026
Comment on lines
+42
to
+58
| message KemCiphertext { | ||
| KemAlgorithm algorithm = 1; | ||
| bytes ciphertext = 2; // `Nenc` bytes long. | ||
| } | ||
|
|
||
| // The results of a Decaps operation. | ||
| message KemSharedSecret { | ||
| KemAlgorithm algorithm = 1; | ||
| bytes secret = 2; // `Nsecret` bytes long. | ||
| } | ||
|
|
||
| message HpkePayload { | ||
| HpkeAlgorithm algorithm = 1; | ||
| bytes kem_ciphertext = 2; // `Nenc` bytes long. | ||
| bytes payload_ciphertext = 3; // Encrypted data. | ||
| bytes authentication_tag = 4; // `Nt` bytes long. | ||
| } |
Collaborator
There was a problem hiding this comment.
These are not really involved with key_claims, should we either move these definitions or rename the file?
Collaborator
Author
There was a problem hiding this comment.
moved to keymanager/km_common/proto/payload.proto
atulpatildbz
force-pushed
the
keyclaims_proto
branch
from
f0554da to
b5caaaf
Compare
adds the `KeyClaims` proto definition in `keymanager/km_common/proto/` which includes `VmAttestation`, `KeyAttestation`, and related messages for key protection and attestation. It also adds `proto/gen_keymanager.sh` to generate Go code for keymanager protos.
…for algorithms.proto Removed VM attestation related messages from key_claims.proto, they will be added in github.com/GoogleCloudPlatform/confidential-space separately Since 2 proto files are in the same directory, i changed the package name in algorithms.proto to keymanager
moved operational payload structures (KemCiphertext, KemSharedSecret, HpkePayload) out of key_claims.proto, which should only be used for attestation identity claims.
atulpatildbz
force-pushed
the
keyclaims_proto
branch
from
b5caaaf to
6965af8
Compare
alexmwu
approved these changes
Feb 28, 2026
yanchengchen7
approved these changes
Feb 28, 2026
mayafleischer
pushed a commit
to mayafleischer/go-tpm-tools
that referenced
this pull request
Mar 4, 2026
Adds Protobufs for KeyClaims **Key Changes:** * **Protobuf Definitions:** Adds `algorithms.proto`, `key_claims.proto`, and `payload.proto` to `keymanager/km_common/proto/` * **Generation script:** `proto/gen_keymanager.sh` to easily build and update the corresponding Go bindings (`.pb.go`). * Rename the package algorithms to keymanager.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds the
KeyClaimsproto definition inkeymanager/km_common/proto/which includesVmAttestation,KeyAttestation, and related messages for key protection and attestation.It also adds
proto/gen_keymanager.shto generate Go code for keymanager protos.